do not mock RequestStack in tests
#53500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 11, 2024
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
OskarStark
reviewed
Jan 11, 2024
src/Symfony/Component/HttpKernel/Tests/EventListener/LocaleListenerTest.php
Outdated
Show resolved
Hide resolved
|
As this hardens the codebase, I am for target branch 5.4 |
xabbuh
force-pushed
the
request-stack-mock
branch
from
59db2b1 to
527ef4a
Compare
nicolas-grekas
approved these changes
Jan 11, 2024
OskarStark
changed the title
RequestStack in tests
|
Thank you @xabbuh. |
xabbuh
added a commit
that referenced
this pull request
Jan 12, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [Security] do not mock the RequestStack class | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT I forgot to push these changes for #53500 Commits ------- 88e519d do not mock the RequestStack class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.