Skip to content

Conversation

@silasjoisten
Copy link
Contributor

Q A
Branch 7.2
Bug fix? no
New feature? no
Deprecations? no
License MIT

@carsonbot carsonbot added this to the 7.2 milestone Oct 10, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "magic" number is OK here, no pun intended. I don't think we need this change.

@carsonbot carsonbot changed the title Use constant instead of magic number [HttpFoundation] Use constant instead of magic number Oct 10, 2024
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such changes were rejected in the past

@GromNaN GromNaN closed this Oct 10, 2024
@silasjoisten silasjoisten deleted the patch-1 branch October 10, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants