[ErrorHandler] Improve an error message #59899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Mar 3, 2025
Contributor
|
As a bugfix? |
Contributor
|
IMO, it should be a feature, if it's merged as a bug, people doing |
Contributor
|
Failures look related btw 🙂 |
Contributor
AFAIK we don't give BC promise for exception messages |
Contributor
Noted, thanks! |
alexandre-daubois
approved these changes
Mar 3, 2025
yceruto
approved these changes
Mar 3, 2025
fabpot
force-pushed
the
undefined-function-better-error-message
branch
from
a288967 to
126f556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got this error message this morning and I was confused.