[SecurityBundle] also deprecate the internal rate limiter factory alias

[xabbuh]

Q	A
Branch?	7.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

[xabbuh]

registerAliasForArgument() can register a second alias (that's what I call "internal alias" here):

symfony/src/Symfony/Component/DependencyInjection/ContainerBuilder.php

Lines 1475 to 1477 in ae30d7c

	if ($parsedName !== $name) {
	$this->setAlias('.'.$type.' $'.$name, $type.' $'.$parsedName);
	}

[alexandre-daubois]

Actually should we deprecate it? If it is internal, just like @internal classes, I'm not sure we should do it?

[xabbuh]

not sure if we can bypass the deprecation here then in a good way:

symfony/src/Symfony/Component/DependencyInjection/Compiler/ResolveReferencesToAliasesPass.php

Lines 62 to 65 in ae30d7c

	if (!$referencingDefinition->isDeprecated()) {
	$deprecation = $alias->getDeprecation($id);
	trigger_deprecation($deprecation['package'], $deprecation['version'], rtrim($deprecation['message'], '. ').'. It is being referenced by the "%s" '.($container->hasDefinition($this->currentId) ? 'service.' : 'alias.'), $this->currentId);
	}

[nicolas-grekas]

Thank you @xabbuh.