Skip to content

Conversation

@mamazu
Copy link
Contributor

@mamazu mamazu commented Sep 6, 2025

Q A
Branch? 7.4
Bug fix? no (fixing tests)
New feature? no
Deprecations? no
Issues -
License MIT

In the PR #61308 the error message was updated as well as the tests for the question helper. But it looks like there is also the CommandTesterTest that requires updating the error message.

@mamazu mamazu requested a review from chalasr as a code owner September 6, 2025 12:29
@carsonbot carsonbot added this to the 7.4 milestone Sep 6, 2025
@carsonbot carsonbot changed the title Fixing expected error messages for missing inputs Fixing expected error messages for missing inputs Sep 6, 2025
@mamazu mamazu marked this pull request as draft September 6, 2025 12:46
And distinct so that we can see in the test which MissingInputException has been thrown.
@GromNaN GromNaN added the Console label Sep 7, 2025
@carsonbot carsonbot changed the title Fixing expected error messages for missing inputs [Console] Fixing expected error messages for missing inputs Sep 7, 2025
@nicolas-grekas
Copy link
Member

Let me close as fixed by #61672

@mamazu mamazu deleted the fixing_tests branch September 8, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants