[Lock] do not support sensitive option entries #61737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 12, 2025
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
src/Symfony/Component/Lock/Bridge/DynamoDb/Store/DynamoDbStore.php
Outdated
Show resolved
Hide resolved
Member
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 15, 2025
This PR was merged into the 7.4 branch. Discussion ---------- [Lock] fix DynamoDB integration test | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT I accidentally broke the integration test in #61737 when changing the visibility of the `createTable()` method to `private`. Commits ------- f3b4822 fix DynamoDB integration test
stof
reviewed
Sep 15, 2025
| } | ||
|
|
||
| public function createTable(): void | ||
| private function createTable(): void |
Member
There was a problem hiding this comment.
shouldn't createTable stay public, to make it possible to use it in a setup script.
Some projects will use a low-priviledge account for the runtime usage, that is not able to create a table, but is allowed to access the specific table being used. They will then have a setup script run with different AWS credentials with higher priviledges to create the table. If this method is not public, they cannot rely on it as their implementation, having to duplicate it (hoping it is in sync), or use Reflection to call a private method (not covered by our BC policy).
Having such setup method public is the common case for our stores in various components (see PdoStore for instance)
nicolas-grekas
added a commit
that referenced
this pull request
Sep 15, 2025
This PR was merged into the 7.4 branch. Discussion ---------- [Lock] make `createTable()` public again | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | #61737 (comment) | License | MIT Commits ------- 881879d make createTable() public again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.