[Config] Add Node::getDeprecationMessage() with full message
#61799
+44
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Sep 20, 2025
| /** | ||
| * @param string $node The configuration node name | ||
| * @param string $path The path of the node | ||
| * @return array{package: string, version: string, message: string} |
Member
Author
There was a problem hiding this comment.
We can also update the returned message to prepend the package and version. But this could duplicate the "since ..." prefix if its prepended somewhere outside. This method is not used in Symfony outside of the Config component.
fabpot
requested changes
Sep 21, 2025
GromNaN
force-pushed
the
node-dep-mess
branch
from
144f752 to
68f8a4a
Compare
fabpot
approved these changes
Sep 22, 2025
fabpot
force-pushed
the
node-dep-mess
branch
from
68f8a4a to
ebb4d65
Compare
Member
|
Thank you @GromNaN. |
GromNaN
commented
Oct 20, 2025
|
|
||
| $message = strtr($this->deprecation['message'], ['%node%' => $this->getName(), '%path%' => ($parent ?? $this->parent ?? $this)->getPath()]); | ||
| if ($this->deprecation['package'] || $this->deprecation['version']) { | ||
| $message = \sprintf('Since %s %s: ', $this->deprecation['package'], $this->deprecation['version']).$message; |
Member
Author
There was a problem hiding this comment.
Would make more sense.
Suggested change
| $message = \sprintf('Since %s %s: ', $this->deprecation['package'], $this->deprecation['version']).$message; | |
| $message = \sprintf('Since %s %s: %s', $this->deprecation['package'], $this->deprecation['version'], $message); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids repetition of identical code in Yaml and XML dumpers, PHP config generator, and the upcoming JSON schema generator.