[JsonStreamer] Rebuild cache on class update

[mtarld]

Q	A
Branch?	7.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #62030
License	MIT

Having outdated stream PHP files can lead to unexpected results.

Therefore, this PR leverages the use of ConfigCache to regenerate streamers on resource (ie: class) change.

[MatTheCat]

Thanks for looking into this! Unfortunately this didn’t solve the issue, maybe because the target object is not necessarily a resource?

[mtarld]

Indeed, I registered objects as ReflectionClassResource so that objects are tracked no matter where they come from, let me know if it solves the issue 🙂

[mtarld]

But to work, the object needs, of course, to be marked with #[JsonStreamable] (which is what's written in the documentation).

[MatTheCat]

The documentation says it’s optional?

I’m still not seeing any difference though.

[stof]

see my comment on the issue. Making the cache warmer required and invalidating the whole container cache when the streamable class gets edited is overkill IMO.
In dev, we should rather keep generating the streamable classes on demand (there will be tons of cases where you will edit something in your project without running code for all your streamable classes, where a required class warmer would slow down your dev env for nothing), but with proper cache invalidation.

[mtarld]

@stof, the PR has been updated to leverage config cache factories (like in translator and router).

Let me know if it's the right approach (I'm not used to that).

[MatTheCat]

This is better but it seems the cache won’t be refreshed if a nested class changes.

[mtarld]

Low deps tests should be fixed once merged.

[nicolas-grekas]

Low deps tests should be fixed once merged.

let me doubt about this: merging up won't change anything to lowest deps

[mtarld]

My thought was:

• FrameworkBundle is failing with a too low version on JsonStreamer (<=7.3.4 which is without config cache)
• If FrameworkBundle is requiring JsonStreamer at the next version (^7.3.5), it should work again

Thinking to this again, I'm indeed wrong, because FrameworkBundle:^7.3.5 can still require JsonStreamer:^7.3.2 for example. Therefore:

• maybe we need to add something like a conflict to symfony/json-streamer: <7.3.5?
• or maybe I update the test with a class_exists on StreamerDumper in the test to make it dependent of that fix?

WDYT?

[nicolas-grekas]

Thank you @mtarld.