[Config] Deprecate setting a default value to a node that is required #62090
+62
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GromNaN
commented
Oct 16, 2025
GromNaN
commented
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Issues | Fix #62076 |
| License | MIT |
carsonbot
changed the title
GromNaN
force-pushed
the
config-default-required
branch
2 times, most recently
from
3afbdb8 to
5cef122
Compare
GromNaN
commented
Oct 16, 2025
|
|
||
| public function testUnknownPackageThrowsException() | ||
| { | ||
| $node = new ArrayNodeDefinition('node'); |
There was a problem hiding this comment.
Moving expectException just before the call that produces it to be more specific.
Comment on lines
+111
to
+115
| yield [ArrayNodeDefinition::class, []]; | ||
| yield [ScalarNodeDefinition::class, null]; | ||
| yield [BooleanNodeDefinition::class, false]; | ||
| yield [StringNodeDefinition::class, 'default']; | ||
| yield [VariableNodeDefinition::class, 'default']; |
There was a problem hiding this comment.
Testing various child classes as they could have different behaviors.
GromNaN
force-pushed
the
config-default-required
branch
from
5cef122 to
e3e3c1c
Compare
GromNaN
force-pushed
the
config-default-required
branch
2 times, most recently
from
9549b89 to
e19d3ed
Compare
stof
approved these changes
Oct 17, 2025
derrabus
reviewed
Oct 17, 2025
src/Symfony/Component/Config/Definition/Builder/NodeDefinition.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Config/Definition/Builder/NodeDefinition.php
Outdated
Show resolved
Hide resolved
GromNaN
force-pushed
the
config-default-required
branch
from
e19d3ed to
8a1bb6d
Compare
GromNaN
force-pushed
the
config-default-required
branch
from
8a1bb6d to
5a47df9
Compare
|
I updated the messages of the deprecation and the future exceptions. |
xabbuh
added
the
❄️ Feature Freeze
xabbuh
approved these changes
Oct 19, 2025
| ------ | ||
|
|
||
| * Deprecate accessing the internal scope of the loader in PHP config files, use only its public API instead | ||
| * Deprecate setting a default value to a node that is required, and vice versa |
There was a problem hiding this comment.
Suggested change
| * Deprecate setting a default value to a node that is required, and vice versa | |
| * Deprecate setting a default value to a node that is required |
I think it's understandable like this?
There was a problem hiding this comment.
Sorry I missed your comment and merged.
I used a different wording for the 8.0 branch: #62109
alexandre-daubois
approved these changes
Oct 19, 2025
GromNaN
added a commit
that referenced
this pull request
Oct 22, 2025
…isRequired()` and `defaultValue()` (GromNaN) This PR was merged into the 8.0 branch. Discussion ---------- [Config] Ensure configuration nodes do not have both `isRequired()` and `defaultValue()` | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix #62076 | License | MIT Convert deprecation introduced in #62090 into an exception. Commits ------- 59f69e0 [Config] Ensure configuration nodes does not have both isRequired() and defaultValue()
symfony-splitter
pushed a commit
to symfony/config
that referenced
this pull request
Oct 22, 2025
…isRequired()` and `defaultValue()` (GromNaN) This PR was merged into the 8.0 branch. Discussion ---------- [Config] Ensure configuration nodes do not have both `isRequired()` and `defaultValue()` | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix symfony/symfony#62076 | License | MIT Convert deprecation introduced in symfony/symfony#62090 into an exception. Commits ------- 59f69e0127b [Config] Ensure configuration nodes does not have both isRequired() and defaultValue()
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.