[Config] Add getter of definition nodes properties #62122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
config-getter
branch
2 times, most recently
from
b34371c to
4a2271e
Compare
stof
reviewed
Oct 22, 2025
| $nullableBooleanNode->setDefaultValue(null); | ||
|
|
||
| yield [$nullableBooleanNode, 'bool|null']; | ||
| yield [new BooleanNode('node', nullable: true), 'bool|null']; |
Member
There was a problem hiding this comment.
please don't use named parameters. They are not covered by BC. Using the public API in tests can help detect some unintended BC breaks (if we have to edit those tests for unrelated reasons)
Member
There was a problem hiding this comment.
If you update this occurrence, could you also please fix the other ones in the provider?
Member
Author
There was a problem hiding this comment.
Updated, please note the inconsistency in the constructor signature. The pathSeparator is before node-specific options in BooleanNode but after in IntegerNode
GromNaN
commented
Oct 22, 2025
| * | ||
| * @return list<array{0: mixed, 1: mixed}> | ||
| */ | ||
| public function getEquivalentValues(): array |
Member
Author
There was a problem hiding this comment.
This one may not be necessary.
GromNaN
force-pushed
the
config-getter
branch
from
885c1cb to
2d30b88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b68f0e6, the methods
NumericNode::getMin()etNumericNode::getMax()have been added so that they can be used to generate the array shape.Other getters would be necessary for the
JsonSchemagenerator (#59620)BaseNode::getEquivalentValues()indicate ifnull,true,falseare allowed valuesBooleanNode::isNullable()indicates ifnullis an allowed valueVariableNode::getAllowEmptyValue()indicates if an empty string is allowed