Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@rogeriopradoj
Copy link
Contributor

More review of chapter 1.

kleberhs007 and others added 3 commits November 29, 2011 15:51
Signed-off-by: Kleber Hamada Sato <kleberhs007@yahoo.com>
Finish translation review of chapter 01 from Jobeet tutorial.
@hidenorigoto
Copy link
Contributor

@rogeriopradoj
This PR is OK, could you merge by yourself?

@rogeriopradoj
Copy link
Contributor Author

Just to confirm, PR is a Pull Request, ok? I'm asking because I am new in
the world of git and github.

If is what I am thinking, ok, I can do for sure.

Thanks,

Rogerio

On Thu, Dec 1, 2011 at 2:30 PM, Hidenori Goto <
reply@reply.github.com

wrote:

@rogeriopradoj
This PR is OK, could you merge by yourself?


Reply to this email directly or view it on GitHub:
#22 (comment)

rogeriopradoj added a commit that referenced this pull request Dec 1, 2011
@rogeriopradoj rogeriopradoj merged commit b636cfe into symfony:master Dec 1, 2011
@hidenorigoto
Copy link
Contributor

You are right, PR is Pull Request in Git world.

@rogeriopradoj
Copy link
Contributor Author

Thank you.

Merge done.

I think now I can do some "complete processes completely"
(translation/review, commit, push, pull request, merge).

I'll keep asking you when I got more questions.

See ya,

Rogerio

On Thu, Dec 1, 2011 at 10:09 PM, Hidenori Goto <
reply@reply.github.com

wrote:

You are right, PR is Pull Request in Git world.


Reply to this email directly or view it on GitHub:
#22 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants