[Site] Use monospace system font #1121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This time I can see the difference easily on https://smnand.re/w/b68eda/ - but I don't personally mind it. Anyone have a strong opinion on the before/after of the code blocks in the link above? Also, this will need a rebase now - after merging your other PR's ;) |
smnandre
force-pushed
the
site/monospace-system-font
branch
from
fb94f66 to
e9ffa85
Compare
Member
Author
|
We can play with the multiple font settings / axes.. I find it more readable like that but it's only a personal opinion. |
Member
|
Let's roll with it - if there are any major objections (which I doubt), then we can talk about those when they happen. Thanks! |
Member
|
Merged - not sure why GH didn't see that |
weaverryan
added a commit
that referenced
this pull request
Sep 19, 2023
This PR was merged into the 2.x branch. Discussion ---------- [Site] Use monospace system font TL;DR; i suggest to use native system fonts instead of webfont. Follow #1119, this time for the `monospace` font, with the same reasons. Again, I put online some before/after captures* with a slider tool to compare. (* made on macOS Ventura / Firefox) Captures here: https://smnand.re/w/b68eda/ <img width="1565" alt="slider-comparaison" src="https://github.com/symfony/ux/assets/1359581/c1fd99cd-bc38-4279-9e5f-46f175903d0b"> I made two separate PR because developpers tend to be a little more sensible about code fonts :) Commits ------- e9ffa85 Use monospace system font
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR; i suggest to use native system fonts instead of webfont.
Follow #1119, this time for the
monospacefont, with the same reasons.Again, I put online some before/after captures* with a slider tool to compare.
(* made on macOS Ventura / Firefox)
Captures here: https://smnand.re/w/b68eda/
I made two separate PR because developpers tend to be a little more sensible about code fonts :)