[LiveComponent] use "full" serializer for NormalizerBridgePropertyHydrator #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
Nov 16, 2021
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
makes sense - if there are performance issues, we can find and worry about them later :)
Member
|
Thank you Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This injects the entire serializer into
NormalizerBridgePropertyHydrator. Previously, it was just theDateTimeNormalizer. We originally decided it would be best to "pick and choose" which normalizers we would enable by default. The reasoning was we wanted to prevent theDoctrineEntityPropertyHydratorbeing called when hydrating/dehydrating every live prop. This hydrator requires checking with doctrine if the property's type-hint is a doctrine entity. I believe we were concerned about the performance overhead. Maybe this is negligible? Maybe we can adjust this hydrator to be more performant?