[RFC][Site] replace highlight.js with tempest/highlight
#1742
Conversation
| {% if height %} style="--height: {{ height }}" {% endif %} | ||
| data-clipboarder-target="source" | ||
| ><code {% if highlight %} data-code-highlighter-target="codeBlock" {% endif %}>{{ __code ? __code|trim|raw : code }}</code></pre> | ||
| ><code>{{ __code ? __code|trim|raw : code }}</code></pre> |
There was a problem hiding this comment.
I broke the highlighting here so this needs to be fixed. Does highlight.js detect the language?
| - uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: 8.1 | ||
| php-version: 8.3 |
It's not that hard i think. Let's add this to my ever-growing-todo-list 😅 |
|
That's a nice improvement, especially for web perfs 👀 For |
WebMamba
left a comment
WebMamba
left a comment
There was a problem hiding this comment.
Humm sorry but I think if do this move we should completly remove highligh.js even in translator-demo-controller 😅
I agree, closing. |
| use Tempest\Highlight\Highlighter; | ||
|
|
||
| /** | ||
| * TODO: remove this class when/if https://github.com/tempestphp/highlight/pull/102 is merged. |
…(kbond) This PR was merged into the 2.x branch. Discussion ---------- [Site] switch from `highlight.js` to `tempest/highlight` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | n/a | License | MIT Continuation of #1742. I now fully removed highlight.js. Commits ------- 22ef22e [Site] switch from `highlight.js` to `tempest/highlight`
5 participants
(depends on #1740)
I couldn't remove
highlight.jsentirely astranslation-demo-controller.jsstill requires it and I don't think we can easily refactor it out. I don't really want to maintain two syntax highlighters (+styling) so I'm not sure this PR is worth it...