Skip to content

Adjust GHA to account for fabbot #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2024
Merged

Adjust GHA to account for fabbot #1795

merged 1 commit into from
Apr 30, 2024

Conversation

@kbond
Copy link
Member

@kbond kbond commented Apr 27, 2024

Q A
Bug fix? no
New feature? no
Issues n/a
License MIT

fabbot now handles cs

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 27, 2024
@smnandre
Copy link
Member

smnandre commented Apr 27, 2024

Does he uses our phpcsfixer config ?

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 27, 2024
@kbond
Copy link
Member Author

kbond commented Apr 30, 2024

Does he uses our phpcsfixer config ?

This is my understanding, yes.

This PR has been stuck on pending and I see a few others like this. Some seem to pass ok though...

@kbond kbond merged commit 58c69b7 into symfony:2.x Apr 30, 2024
@kbond kbond deleted the fabbot branch April 30, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smnandre smnandre smnandre approved these changes

Assignees

No one assigned

Labels

Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kbond @smnandre @carsonbot