PHP CS Fixer: update usage #3263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
approved these changes
Jan 3, 2026
Member
Kocal
left a comment
Kocal
left a comment
There was a problem hiding this comment.
Thanks you for working on this!
| public array $products = []; | ||
| } | ||
|
|
||
| // @php-cs-fixer-ignore fully_qualified_strict_types Due to https://github.com/symfony/ux/pull/2768#issuecomment-2905091761 |
Member
There was a problem hiding this comment.
Can we move this line at the very top?
Member
Author
There was a problem hiding this comment.
i recommend it on bottom, to avoid any placement conflict with license header, declare strict etc - but you can put it anywhere in the file
Member
There was a problem hiding this comment.
I understand, but I think it would be clearer for a human to have this comment at the beginning of the file, especially since it is quite long here.
Member
Author
There was a problem hiding this comment.
i moved it. if you prefer another place, please locate it at place of your preference
carsonbot
added
Status: Reviewed
Member
|
Can we also remove the PHP-CS-Fixer configuration file from ux.symfony.com? |
Kocal
added a commit
to Kocal/symfony-ux
that referenced
this pull request
Jan 3, 2026
Member
Author
|
removed as requested |
Member
|
Thanks @keradus, that's super appreciated! |
Kocal
added a commit
to Kocal/symfony-ux
that referenced
this pull request
Jan 3, 2026
Kocal
added a commit
that referenced
this pull request
Jan 3, 2026
This PR was merged into the 2.x branch. Discussion ---------- Run Twig-CS-Fixer on all repo's files, follow #3263 | Q | A | -------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Documentation? | no <!-- required for new features, or documentation updates --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT I'm not sure to understand why Fabbot Twig-CS-Fixer check is failing, but too much files are being linted: ``` [OK] Files linted: 62, notices: 0, warnings: 0, errors: 0 Error: Twig-CS-Fixer found style issues. Please apply the patch below. git apply - <<'EOF_PATCH' Only in b/: a EOF_PATCH Then commit the changes and push to your PR branch. ``` I'm not able to reproduce it locally **EDIT:** I forgot to remove `b` directory 🤦🏻 Commits ------- d5ae9b7 Run Twig-CS-Fixer on all repo's files, follow #3263
Kocal
added a commit
that referenced
this pull request
Jan 3, 2026
* 2.x: Run Twig-CS-Fixer on all repo's files, follow #3263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
best to review commit by commit