Skip to content

[Toolkit][Shadcn] Add menubar and popover recipes#3468

Closed
Amoifr wants to merge 2 commits intosymfony:3.xfrom
Amoifr:feat/toolkit-shadcn-menubar-popover
Closed

[Toolkit][Shadcn] Add menubar and popover recipes#3468
Amoifr wants to merge 2 commits intosymfony:3.xfrom
Amoifr:feat/toolkit-shadcn-menubar-popover

Conversation

@Amoifr
Copy link
Copy Markdown
Contributor

@Amoifr Amoifr commented Apr 14, 2026

Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? no
Issues Part of #3233
License MIT

Hi 👋

Two more recipes from #3233 (previous batches: #3464, #3466, #3467). Both are JS-free and rely on native CSS / HTML behaviour:

Each recipe has Usage.html.twig, Demo.html.twig, and passing snapshot tests (252 tests, 504 assertions).

Thanks! 🙏

@Kocal
Copy link
Copy Markdown
Member

Kocal commented Apr 14, 2026

Can you change the base branch to 3.x please, the 2.x is not maintained anymore.

Thanks!

Status: Needs work

@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Apr 14, 2026
@Amoifr Amoifr force-pushed the feat/toolkit-shadcn-menubar-popover branch from 4d0c2fe to 2494969 Compare April 15, 2026 06:19
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
LazyImage
controller.d.ts 395 B / 257 B Removed
controller.js 904 B / 457 B Removed
Map
abstract_map_controller.d.ts 7.6 kB / 1.49 kB 7.29 kB-4% 📉 / 1.46 kB-2% 📉
abstract_map_controller.js 4.92 kB / 1.4 kB 4.65 kB-5% 📉 / 1.26 kB-10% 📉
Map (Bridge Google)
map_controller.d.ts 10.56 kB / 1.92 kB 10.26 kB-3% 📉 / 1.9 kB-1% 📉
map_controller.js 12.9 kB / 3.19 kB 11.25 kB-13% 📉 / 2.84 kB-11% 📉
Map (Bridge Leaflet)
map_controller.d.ts 9.92 kB / 1.84 kB 9.61 kB-3% 📉 / 1.81 kB-2% 📉
map_controller.js 12.45 kB / 3.36 kB 11.38 kB-9% 📉 / 3.17 kB-6% 📉
Svelte
components.d.ts 200 B / 150 B Removed
components.js 46 B / 69 B Removed
loader.d.ts 435 B / 217 B Removed
loader.js 553 B / 313 B Removed
register_controller.d.ts 384 B / 235 B Removed
register_controller.js 531 B / 303 B Removed
render_controller.d.ts 629 B / 353 B Removed
render_controller.js 1.05 kB / 493 B Removed
Swup
controller.d.ts 1012 B / 360 B Removed
controller.js 1.71 kB / 653 B Removed
TogglePassword
controller.d.ts 896 B / 355 B Removed
controller.js 2.64 kB / 1.07 kB Removed
style.min.css 312 B / 218 B Removed
Typed
controller.d.ts 1.9 kB / 501 B Removed
controller.js 1.8 kB / 638 B Removed

@Amoifr Amoifr changed the base branch from 2.x to 3.x April 15, 2026 06:35
@Amoifr
Copy link
Copy Markdown
Contributor Author

Amoifr commented Apr 15, 2026

Sorry about this — rebased onto 3.x and moved the CHANGELOG entries into the 3.0.0 section. I'd already been reminded about this on a previous PR and still wasn't careful enough on this batch. Thanks for the patience! 🙏

@Amoifr
Copy link
Copy Markdown
Contributor Author

Amoifr commented Apr 18, 2026

Closing in favor of one PR per component (easier to review): #3486 (menubar), #3487 (popover).

@Amoifr Amoifr closed this Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New Feature Status: Needs Review Needs to be reviewed Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants