[Toolkit][Shadcn] Add menubar and popover recipes#3468
Closed
Amoifr wants to merge 2 commits intosymfony:3.xfrom
Closed
[Toolkit][Shadcn] Add menubar and popover recipes#3468Amoifr wants to merge 2 commits intosymfony:3.xfrom
Amoifr wants to merge 2 commits intosymfony:3.xfrom
Conversation
Member
|
Can you change the base branch to 3.x please, the 2.x is not maintained anymore. Thanks! Status: Needs work |
4d0c2fe to
2494969
Compare
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
Sorry about this — rebased onto |
This was referenced Apr 18, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
Two more recipes from #3233 (previous batches: #3464, #3466, #3467). Both are JS-free and rely on native CSS / HTML behaviour:
group/menubar-menu+group-hover/group-focus-withinpattern ashover-card([Toolkit][Shadcn] Add native-select, slider, scroll-area and hover-card recipes #3466) andnavigation-menu([Toolkit][Shadcn] Add input-otp, resizable and navigation-menu recipes #3467). Ships withMenu,Trigger,Content,Item, andSeparatorsub-components.<details>/<summary>. Ships withPopover:Trigger(a styled<summary>) andPopover:Content.Each recipe has
Usage.html.twig,Demo.html.twig, and passing snapshot tests (252 tests, 504 assertions).Thanks! 🙏