[LiveComponent] Make LiveComponentSubscriber safe-by-default#3566
Open
Kocal wants to merge 1 commit into
Open
Conversation
carsonbot
added
Bug
`LiveComponentSubscriber::$testMode` defaulted to `true` in the constructor, which disabled the `Accept: application/vnd.live-component+html` check (documented as the CSRF defense) for any consumer that built the subscriber outside the bundle's compiler pass. The bundle's own `OptionalDependencyPass` already overrode the value to `false` for non-test kernels, so the default never reached production through normal DI — but the unsafe default remained a footgun for manual instantiation, custom containers, or test setups that bypass the pass. Flip the constructor default to `false` and have `OptionalDependencyPass` opt the test kernel in (when `test.client` is defined) instead of opting production out. Same end state for both environments, safer fallback when the pass is not in play.
Kocal
force-pushed
the
security/live-component/testmode-default
branch
from
f1e4358 to
d7b2a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor improvement, to make
LiveComponentSubscriber"safe by default", by setting$testModedefaults tofalse.Note that
LiveComponentSubscriberis an internal class.