[Toolkit] Make component rendering snapshots independent from the libxml version#3693
Merged
Merged
Conversation
…xml version Since I changed how I installed PHP on my machine (from HomeBrew to Nix), it looks like `libxml` was updated and rendered snapshots by not converting "weird symbols" to HTML entities (e.g. `מאומת` stays `מאומת` instead of `×&symfony#158;×&symfony#144;×&symfony#149;×&symfony#158;ת`). I then challenged Claude to write a path to normalize things between my machine and the CI, otherwise I (and other people with recent libxml) were not able to regenerate Toolkit snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I changed how I installed PHP on my machine (from HomeBrew to Nix), it looks like
libxmlwas updated and rendered snapshots by not converting "weird symbols" to HTML entities (e.g.מאומתstaysמאומתinstead ofמאומת).I then challenged Claude to write a path to normalize things between my machine and the CI, otherwise I (and other people with recent libxml) were not able to regenerate Toolkit snapshots.