-
-
Notifications
You must be signed in to change notification settings - Fork 399
Add link utility to link Symfony UX packages to existing Symfony project
#89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like some of Turbo tests are not passing because of This option I've forced |
weaverryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice idea!
…ue (Kocal) This PR was merged into the main branch. Discussion ---------- fix(test:turbo): install doctrine/orm:~2.8.0 to prevent issue | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Cherry-picked commit 3574ff7 from #89 which fixes broken tests in CI. Commits ------- ec03c4b fix(test:turbo): install doctrine/orm:~2.8.0 to prevent issue
…ue (Kocal) This PR was merged into the main branch. Discussion ---------- fix(test:turbo): install doctrine/orm:~2.8.0 to prevent issue | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Cherry-picked commit symfony/ux@3574ff7 from symfony/ux#89 which fixes broken tests in CI. Commits ------- ec03c4b fix(test:turbo): install doctrine/orm:~2.8.0 to prevent issue
maxhelias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice to have that here too
|
Thanks @Kocal! |
…ue (Kocal) This PR was merged into the main branch. Discussion ---------- fix(test:turbo): install doctrine/orm:~2.8.0 to prevent issue | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Cherry-picked commit symfony/ux@3574ff7 from symfony/ux#89 which fixes broken tests in CI. Commits ------- ec03c4b fix(test:turbo): install doctrine/orm:~2.8.0 to prevent issue
This PR add a new
linkutility to link Symfony UX packages to an existing Symfony project. It's literally a copy/paste from thelinkutility fromsymfony/symfonybut with different directories and an explicit dependency on Symfony Filesystem component.Demo:

