Bugfix Filename cannot be empty#26
Merged
nitriques merged 2 commits intosymphonists:integrationfrom Nov 22, 2017
wdebusschere:master
Merged
Bugfix Filename cannot be empty#26nitriques merged 2 commits intosymphonists:integrationfrom wdebusschere:master
nitriques merged 2 commits intosymphonists:integrationfrom
wdebusschere:master
Conversation
Member
|
Can you elaborate more on your fix ? |
Member
|
When are you getting an error ? while saving ? |
Contributor
Author
|
I had made a mistake with the code, should have been after this if (!file_exists($filename)) if not there is an error. |
Member
|
It's my fault this bug was introduce: your original PR was ok! Sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.