Bugfix and caching for external files#2
Merged
brendo merged 4 commits intosymphonycms:integrationfrom Jun 16, 2011
michael-e:cache-external
Merged
Bugfix and caching for external files#2brendo merged 4 commits intosymphonycms:integrationfrom michael-e:cache-external
brendo merged 4 commits intosymphonycms:integrationfrom
michael-e:cache-external
Conversation
…rder to cache external files.
This functionality will use the "master" setting at the moment, but we might introduce a URL mode for this later. Caching relies on the Last-Modified header field of an HTTP response.
Member
Author
|
BTW: If we decide to implement this, I could add an explanation to the README... |
Member
Author
|
Bump. Any thoughts about this pull request? |
Member
|
I don't think caching for external files should be enabled by default, couldn't this allow anyone to use JIT to send cached images from their website using another website? |
Member
Author
|
No, it will still require the source website to be in your whitelist. So it has no impact on security. |
Member
|
Excellent, merging... |
brendo
added a commit
that referenced
this pull request
Jun 16, 2011
Fix for JIT serving images that no longer exist. Allow external images to be cached
brendo
pushed a commit
that referenced
this pull request
Mar 10, 2012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request has two parts: