Merged
Conversation
| let session_id = session_response.session_id; | ||
|
|
||
| // Send a prompt - elizacp should respond | ||
| notifications.lock().unwrap().clear(); |
Member
There was a problem hiding this comment.
The problem was a race condition: those notifications were arriving and being properly dispatched, from what I can see, but then they were being cleared here (!). I don't know why this clear is here, it just seems wrong, the "available commands" is sent in response to the start of the session, not the prompt.
jackh726
force-pushed
the
update-10-to-11
branch
from
5f51b6a to
4d3153b
Compare
jackh726
force-pushed
the
update-10-to-11
branch
from
4d3153b to
e7d7310
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One test is still failing
test_new_session_with_config: "Expected /symposium:config command to be available".Not entirely seeing what's wrong. I'm seeing "Sending JSON-RPC message" and then a bit after a ""Method not found", which I imagine is the response.