Conversation
| ClaudePreToolUse, | ||
| #[value(name = "pre-tool-use")] | ||
| #[serde(rename = "PreToolUse")] | ||
| PreToolUse, |
There was a problem hiding this comment.
Why'd you change the name back? My intention with including Claude is that there may be other kinds of hooks in the future that have distinct json formats, and I imagined we'd want to do some normalization on our side.
| #[derive(Debug, Deserialize, Clone)] | ||
| pub struct Hook { | ||
| pub name: String, | ||
| pub event: HookEvent, |
There was a problem hiding this comment.
I guess you removed it because of this -- seems fine, I imagined we'd have a different set of events here.
There was a problem hiding this comment.
The "canonical" events we support.
There was a problem hiding this comment.
Yeah - I don't expect that there will be other types of hooks.
|
|
||
| [installation] | ||
| summary = "Download and install helper" | ||
| commands = ["wget https://example.org/bin/tool"] |
There was a problem hiding this comment.
I imagine we're going to iterate on this quite a bit
There was a problem hiding this comment.
Yeah...not exactly sure the shape here yet.
|
After some discussion with Jack, we decided to merge this and iterate in tree |
2 participants
(still draft, just opening to share)
Before merging, I need to actually process/"forward" the hook output. This currently just passes the same payload to each hook, but I think each successive hook should an "updated" payload. And so, that means we likely should be doing early-returns on e.g.
Block.