fix(clippy): nested ifs/let chains#203
Merged
jackh726 merged 2 commits intoMay 11, 2026
Merged
Conversation
jlizen
commented
May 8, 2026
| } | ||
|
|
||
| // None (past debounce) or Check: check freshness via API | ||
| match self.client.resolve_commit_sha(source).await { |
Member
Author
There was a problem hiding this comment.
@jackh726 this does indeed look like dead code, but is it supposed to be?
Contributor
There was a problem hiding this comment.
shrug idk, I think Niko (or Claude) wrote this code.
nikomatsakis
approved these changes
May 8, 2026
Member
nikomatsakis
left a comment
There was a problem hiding this comment.
All these changes look good to me. Exciting that if foo && let is stable now, I keep forgetting. But before I merge, I'd like to hear from @jackh726 on that dead code question.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Initial pass to address clippy lints, before adding to to CI.
This one has a few because they would have caused merge conflicts otherwise:
All seem reasonable to me
Disclosure questions
AI disclosure.
Confidence level.