Skip to content

fix(clippy): nested ifs/let chains#203

Merged
jackh726 merged 2 commits into
symposium-dev:mainfrom
jlizen:clippy/collapsible-if-and-plugins-misc
May 11, 2026
Merged

fix(clippy): nested ifs/let chains#203
jackh726 merged 2 commits into
symposium-dev:mainfrom
jlizen:clippy/collapsible-if-and-plugins-misc

Conversation

@jlizen
Copy link
Copy Markdown
Member

@jlizen jlizen commented May 8, 2026

What does this PR do?

Initial pass to address clippy lints, before adding to to CI.

This one has a few because they would have caused merge conflicts otherwise:

  • Collapse nested ifs into let chains
  • manual_flatten
  • dead_code
  • option_as_ref_deref

All seem reasonable to me

Disclosure questions

AI disclosure.

  • I used an AI tool for research, autocomplete, or in other minimal ways
  • The AI tool authored small parts of the code (e.g., autocomplete, comments)
  • The AI tool authored large parts of the code

Confidence level.

  • I am very happy with it

Comment thread src/installation/git.rs
}

// None (past debounce) or Check: check freshness via API
match self.client.resolve_commit_sha(source).await {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackh726 this does indeed look like dead code, but is it supposed to be?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shrug idk, I think Niko (or Claude) wrote this code.

@jlizen jlizen requested a review from jackh726 May 8, 2026 21:28
Copy link
Copy Markdown
Member

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look good to me. Exciting that if foo && let is stable now, I keep forgetting. But before I merge, I'd like to hear from @jackh726 on that dead code question.

@jackh726 jackh726 added this pull request to the merge queue May 11, 2026
Merged via the queue into symposium-dev:main with commit 4c68ece May 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants