fix(ink-ui): add tool call display and improve visual stability#163
Merged
laynepenney merged 1 commit intomainfrom Jan 26, 2026
Merged
fix(ink-ui): add tool call display and improve visual stability#163laynepenney merged 1 commit intomainfrom
laynepenney merged 1 commit intomainfrom
Conversation
c71f0b8 to
79bbde5
Compare
Collaborator
Author
Self-Review
Ready to merge. |
- Add addToolCall() and addToolResult() methods to InkUiController - Display tool calls with name and truncated input preview - Display tool results with line count, duration, and error status - Remove early return in activity panel to always show it - Add minimum height padding (3 lines) to prevent layout jumping - Use immutable array construction for activity panel padding - Add comprehensive tests for Ink UI controller (55 tests) - Tool call/result edge cases (special chars, unicode, boundaries) - Status update handling - Confirmation queue (multiple, abort, patterns) - Message streaming (interleaved, unicode) - Worker/reader events - Session selection - Exit and lifecycle Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
Updated with Comprehensive Edge Case TestsAdded 40 more edge case tests (now 55 total): Tool Call Messages (23 tests)
Status Updates (5 tests)
Confirmation Queue (6 tests)
Message Streaming (6 tests)
Worker/Reader Events (6 tests)
Session Selection (4 tests)
Exit/Lifecycle (2 tests)Message Types (5 tests)Total: 2070 tests passing |
79bbde5 to
a53b3cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addToolCall()andaddToolResult()methods toInkUiControllerto display tool calls in the Ink UIChanges
src/ui/ink/controller.tsaddToolCall()andaddToolResult()methodssrc/index.tsonToolCall/onToolResultcallbackssrc/ui/ink/app.tsxtests/ink-ui.test.tsTest plan
codi --ui inkand ask it to read a file🤖 Generated with Claude Code