docs: require tests to pass before merging PRs#44
Merged
laynepenney merged 2 commits intomainfrom Jan 18, 2026
Merged
Conversation
Update PR review process to explicitly require running build and tests before merging. This ensures no broken code reaches main. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The onError callback expects an Error object, not a string. This fixes build errors introduced in a recent merge. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
Self-Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm build && pnpm testbefore mergingsrc/rag/indexer.tswhere strings were passed toonErrorinstead ofErrorobjectsTest plan
🤖 Generated with Claude Code