Skip to content

Sprint 17 ceremony: grip#531

Merged
laynepenney merged 8 commits intomainfrom
sprint-17
Apr 11, 2026
Merged

Sprint 17 ceremony: grip#531
laynepenney merged 8 commits intomainfrom
sprint-17

Conversation

@laynepenney
Copy link
Copy Markdown
Collaborator

Summary

Sprint 17 ceremony PR for grip. All PRs reviewed, merged to sprint-17, tests green.

Changes (7 commits)

Features:

Bug fixes:

Tests:

Chores:

Verification

  • cargo fmt --all --check: clean
  • cargo test: 48 suites, 0 failures, 4 ignored (expected)
  • All PRs had 2+ review comments before merge

Premium boundary: core OSS (workspace orchestration primitives)

laynepenney and others added 7 commits April 10, 2026 18:31
chore: sync sprint-17 from main (Sprint 16 ceremony)
feat: gr2 apply link operations and state tracking (grip#514)
feat: glob-based link patterns in manifest (grip#521)

Closes #521
test: TDD specs for gr2 apply (grip#514)

Adds 3 unique TDD spec tests (command recognition, workspace requirement, idempotency) alongside the 7 implementation tests from grip#527. All 10 tests green after alignment.
Copy link
Copy Markdown
Collaborator Author

@laynepenney laynepenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ceremony review (Opus). 7 commits, all previously reviewed and merged to sprint-17 with 2+ reviews each. cargo fmt clean, 48 test suites pass (0 failures). Commit log matches PR descriptions. grip#401 (branch switch) and grip#429 (org URL) bug fixes verified with regression tests. gr2 apply link operations and glob patterns extend the materialization pipeline. Ready for ceremony merge.

@laynepenney
Copy link
Copy Markdown
Collaborator Author

Atlas second-pass review: one correctness risk in the new gr2 apply link path. PlanBuild records link ops with src/dest/kind, but not the unit path. Later guard_for_apply() validates link destinations by reading parameters["path"] and otherwise falling back to agents/{unit_name}. That means any unit with a non-default path can be validated against the wrong destination: false-negative if the real target already exists, or false-positive if agents/{name} exists but the real unit path is elsewhere. I think link ops need to carry the unit path explicitly (or validation should look it up from unit_spec the same way apply() does) before this ceremony merge.

@laynepenney laynepenney merged commit 8e5e4b6 into main Apr 11, 2026
9 of 10 checks passed
@laynepenney laynepenney deleted the sprint-17 branch April 11, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant