Added console_script, updated version and added configurable extraction thresholds #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
kartiknagappa
approved these changes
Aug 17, 2022
kartiknagappa
left a comment
kartiknagappa
left a comment
There was a problem hiding this comment.
Looks good
Something for the future: would be great to have the parser version embedded in the parsed log as well. That way we can tell which version of parser was used for a specific log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all. Now users can invoke the script like any other console command and check the version, e.g.
This also parameterizes the safety thresholds for extracting archives to better fit the configuration in sync_backend.
https://synccomputing.atlassian.net/browse/PROD-424