Prod 411 hui adobe parser error databricks on azure #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 18, 2022 20:42
|
Kudos, SonarCloud Quality Gate passed!
|
NKSync
reviewed
Aug 19, 2022
| # Sometimes an SQL event will be missing. To be informative, both | ||
| # events must be present. But this information is not critical, so | ||
| # if either event is missing then simply reject the SQL data | ||
| if "start_time" not in sql.keys() or "end_time" not in sql.keys(): |
There was a problem hiding this comment.
Not critical, but just to understand:
Could you do just if "end_time" not in sql.keys(). This is on the assumption that if an end_time exists, then a start_time should as well.
Contributor
Author
There was a problem hiding this comment.
This won't work because "start_time" and "end_time" come from separate events in the Spark eventlog. So it's possible for one, or other other, or both to be missing.
gorskysd
deleted the
PROD-411-hui-adobe-parser-error-databricks-on-azure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes SQL Submission or Completion events are missing which throws an error. However, these events are not critical for the predictor run. This solution bypasses the problem by neglecting the SQL data for any queries for which either the Submission or Completion events is missing.
Also added a test for this case which indicates the effect on the sqlData dataframe.
Also modified version.