PROD-1307 Timeline upgrade (library) #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorskysd
requested review from
CaymanWilliams,
brandon-kaplan,
eheinlein-sync and
rmoneys
and removed request for
brandon-kaplan
gorskysd
changed the title
syncbrian
reviewed
Nov 21, 2023
| volumes_response = Response(error=DatabricksError(message=missing_message("ebs volumes"))) | ||
| else: | ||
| volumes_response = Response(result={"Volumes": cluster_info.get("Volumes")}) | ||
| volumes_response = Response(result=cluster_info.get("volumes")) |
Contributor
There was a problem hiding this comment.
Just want to make confirm the capitalization change of "volume" here is expected
Contributor
Author
There was a problem hiding this comment.
yep this is expected, that was part of the "de-nesting" that I talked about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://synccomputing.atlassian.net/browse/PROD-1307
Upgrade to the cluster monitoring for both aws-databricks and azure-databricks. For each instance that is added to the cluster (defined as having the cluster tag), the
instances_timelinelist keeps track of the continuous intervals where those instances first and last seen running.I took this opportunity to reshape the cluster report payload to reduce the unnecessary double-nesting of some fields. Although this wasn't strictly necessarily, it rather significantly reduces the complexity of processing in multiple areas both within syncsparkpy and in the backend. Accommodating this change in the backend to maintain backwards compatibility was straightforward and will be well tested.
Corresponding backend PR: https://github.com/synccomputingcode/sync_backend/pull/445
Slide deck with testing results: https://docs.google.com/presentation/d/1x05FDH3xRkANAo0PchKeBUu9ZFxicHFP3m11dnhxqj0/edit#slide=id.g29bb9035aeb_0_71