add get-submission to the cli #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorskysd
commented
Nov 15, 2023
Comment on lines
+147
to
+152
| def get_project_submissions(self, project_id: str, params: dict = None) -> dict: | ||
| return self._send( | ||
| self._client.build_request( | ||
| "GET", f"/v1/projects/{project_id}/submissions", params=params | ||
| ) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This one doesn't get used (yet), but I included for parity with the get_project_recommendations method elsewhere in this file.
rmoneys
approved these changes
Nov 15, 2023
| ) | ||
| ) | ||
|
|
||
| def get_project_submissions(self, project_id: str, params: dict = None) -> dict: |
Contributor
There was a problem hiding this comment.
**params might make for a friendlier interface so long as we don't want to call any params out.
gorskysd
deleted the
PROD-1363-add-get-submission-operation-to-the-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just to make our lives easier.