-
Notifications
You must be signed in to change notification settings - Fork 2
Update Create Project #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -1,4 +1,4 @@ | |||
| """Library for leveraging the power of Sync""" | |||
| __version__ = "0.5.3" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is part of a major new initiative (i.e. instance size optimization), does this deserve a more significant version number update? Should we make it 0.6.0? More generally, how should we be thinking about upgrades to version number and what constitutes a major vs. a minor one, etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@syncbrian Based on our conversation from slack, I've changed the version back down to 0.5.3 (i.e. left it unchanged) with the thinking that the version number will be updated to 0.6.0 at the next release. Let me know if this sounds right to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup that sounds right!
syncbrian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we allowing the users to update this flag via the cli? At the moment, I only see an update to the api wit the new field being set to false and no updates to the actual cli command to allow users to flip the flag
|
@syncbrian Eventually yes, we think we will let users update this flag via a switch on the UI. For now, this change is sufficient to unblock building out the backend. I think the final piece of updating the cli can be done a few weeks from now, as the backend takes shape. |
|
Cool makes sense, just wanted to verify that was the intention 👍 |
syncbrian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For instance size optimization, the project models and database table now contain a new flag that holds the state of whether instance size optimization is enabled. This PR updates the library functions and endpoints that handle project creation and updates.