Skip to content

Conversation

@aditya-jaishankar
Copy link
Contributor

For instance size optimization, the project models and database table now contain a new flag that holds the state of whether instance size optimization is enabled. This PR updates the library functions and endpoints that handle project creation and updates.

@@ -1,4 +1,4 @@
"""Library for leveraging the power of Sync"""
__version__ = "0.5.3"
Copy link
Contributor Author

@aditya-jaishankar aditya-jaishankar Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is part of a major new initiative (i.e. instance size optimization), does this deserve a more significant version number update? Should we make it 0.6.0? More generally, how should we be thinking about upgrades to version number and what constitutes a major vs. a minor one, etc.?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm good question, I'm not sure what the versioning scheme has been in the past but agree that this is more than a simple fix and because it's not breaking changes the minor version update here would make sense. Unless @gorskysd or @singhals has some input here, I'd say we move this up to 0.6.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syncbrian Based on our conversation from slack, I've changed the version back down to 0.5.3 (i.e. left it unchanged) with the thinking that the version number will be updated to 0.6.0 at the next release. Let me know if this sounds right to you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup that sounds right!

Copy link
Contributor

@syncbrian syncbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we allowing the users to update this flag via the cli? At the moment, I only see an update to the api wit the new field being set to false and no updates to the actual cli command to allow users to flip the flag

@aditya-jaishankar
Copy link
Contributor Author

@syncbrian Eventually yes, we think we will let users update this flag via a switch on the UI. For now, this change is sufficient to unblock building out the backend. I think the final piece of updating the cli can be done a few weeks from now, as the backend takes shape.

@syncbrian
Copy link
Contributor

Cool makes sense, just wanted to verify that was the intention 👍

Copy link
Contributor

@syncbrian syncbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aditya-jaishankar aditya-jaishankar merged commit ae0b971 into main Jan 5, 2024
@aditya-jaishankar aditya-jaishankar deleted the PROD-1482-update-create-project branch January 5, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants