implement cluster_report_destination_override #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhals
approved these changes
Feb 8, 2024
| def monitor_cluster( | ||
| cluster_id: str, | ||
| polling_period: int = 20, | ||
| cluster_report_destination_override: dict = None, |
Contributor
There was a problem hiding this comment.
is it better to type the None as Optional too?
Suggested change
| cluster_report_destination_override: dict = None, | |
| cluster_report_destination_override: Optional[dict] = None, |
| sleep(polling_period) | ||
|
|
||
|
|
||
| def _define_write_file(file_key, filesystem, bucket): |
Contributor
There was a problem hiding this comment.
Nice moving logic into sub-functions!
Contributor
Author
|
Not going to merge quite yet, id like to revalidate my tests - i missed the hardcoded line in the reporting job that uses latest library |
Contributor
Author
|
worked on the sandbox environment for both monitor cluter and the record run job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
please add a few lines to give the reviewer context on the changes
Relevant Design Doc
Adding the option to pass in a dict of
filesystemandbase_prefixto allow overriding of the logging location for cluster monitoringChecklist
Before formally opening this PR, please adhere to the following standards:
Related Jira Ticket
Add any relevant testing examples or screenshots.
Will test existing functionality remains.
validated retention of existing functionality by pointing our sandbox environment's init script to this branch. Ran with the logging location both to dbfs and s3.
DBFS:
s3:
pulled both files down and validated they populated properly.