Skip to content

Conversation

@gorskysd
Copy link
Contributor

@gorskysd gorskysd commented Feb 10, 2024

Delete the Autotuner/Predictions components of the library.

Overview of changes

  • Change "autotuner/products" endpoint call to "projects/products". (See corresponding backend PR)
  • Delete all downstream occurrences of "autotuner" endpoint calls. Most functions are delete entirely. For a few, only the autotuner fork is deleted.
  • Clean up documentation to remove presence of autotuner and "aws-emr" support
  • Remove the "preference" option from configuration (e.g. ECONOMY), which was autotuner specific
  • Delete autotuner tests. Unfortunately this was all of the test, of which there were few.

https://synccomputing.atlassian.net/browse/PROD-1625

@gorskysd gorskysd self-assigned this Feb 10, 2024
@gorskysd gorskysd marked this pull request as ready for review February 11, 2024 15:32
romainissynced
romainissynced previously approved these changes Feb 12, 2024
Copy link
Contributor

@romainissynced romainissynced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@singhals singhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp because its mostly code removal. PR is just generally too large to do a good review.

Copy link
Contributor

@singhals singhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JK this needs a library version bump, probably a MAJOR version bump because this is removing functionality

@gorskysd gorskysd requested a review from singhals February 12, 2024 23:46
@gorskysd gorskysd merged commit 42fe4ce into main Feb 14, 2024
@gorskysd gorskysd deleted the PROD-1625-remove-autotuner-support branch February 14, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants