Skip to content

WPF-889895-Page Settings Issue Fixes #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2024
Merged

WPF-889895-Page Settings Issue Fixes #1369

merged 6 commits into from
Jun 26, 2024

Conversation

@SatishRaj4377
Copy link
Contributor

@SatishRaj4377 SatishRaj4377 commented Jun 14, 2024

Description

  • Highlighted the property
  • Added question mark to links in "See Also" sections

@SatishRaj4377 SatishRaj4377 self-assigned this Jun 14, 2024
@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 14, 2024

Build Status: INPROGRESS 🔃
Build Location: WPF-889895-PageSettings_Issue_Fixes

@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 14, 2024

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: WPF-889895-PageSettings_Issue_Fixes
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

@SatishRaj4377 SatishRaj4377 changed the base branch from master to hotfix/hotfix-v26.1.35 June 18, 2024 05:28
KarkuvelRajan
KarkuvelRajan requested changes Jun 25, 2024
View reviewed changes
wpf/Diagram/Page-Settings.md Outdated
# Page Settings in WPF Diagram (SfDiagram)

By default, Diagram's page size is decided based on the position of diagramming elements. The size and appearance of the diagram pages can be customized using the [PageSettings](https://help.syncfusion.com/cr/wpf/Syncfusion.UI.Xaml.Diagram.PageSettings.html ) property of SfDiagram.
By default, Diagram's page size is decided based on the position of diagramming elements. The size and appearance of the diagram pages can be customized using the [`PageSettings`](https://help.syncfusion.com/cr/wpf/Syncfusion.UI.Xaml.Diagram.PageSettings.html ) property of SfDiagram.
Copy link
Collaborator

@KarkuvelRajan KarkuvelRajan Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the highlight in properties with a link. Need to highlight the SfDiagram.

wpf/Diagram/Page-Settings.md Outdated
By default, Diagram's page size is decided based on the position of diagramming elements. The size and appearance of the diagram pages can be customized using the [PageSettings](https://help.syncfusion.com/cr/wpf/Syncfusion.UI.Xaml.Diagram.PageSettings.html ) property of SfDiagram.
By default, Diagram's page size is decided based on the position of diagramming elements. The size and appearance of the diagram pages can be customized using the [`PageSettings`](https://help.syncfusion.com/cr/wpf/Syncfusion.UI.Xaml.Diagram.PageSettings.html ) property of SfDiagram.

* The [`PageWidth`](https://help.syncfusion.com/cr/wpf/Syncfusion.UI.Xaml.Diagram.PageSettings.html#Syncfusion_UI_Xaml_Diagram_PageSettings_PageWidth) and [`PageHeight`](https://help.syncfusion.com/cr/wpf/Syncfusion.UI.Xaml.Diagram.PageSettings.html#Syncfusion_UI_Xaml_Diagram_PageSettings_PageHeight) properties of `PageSettings` define the size of the page.
Copy link
Collaborator

@KarkuvelRajan KarkuvelRajan Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the highlight in properties with a link.

@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 25, 2024

Build Status: INPROGRESS 🔃
Build Location: WPF-889895-PageSettings_Issue_Fixes

@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 25, 2024

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: WPF-889895-PageSettings_Issue_Fixes
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 25, 2024

Build Status: INPROGRESS 🔃
Build Location: WPF-889895-PageSettings_Issue_Fixes

@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 25, 2024

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: WPF-889895-PageSettings_Issue_Fixes
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 26, 2024

Build Status: INPROGRESS 🔃
Build Location: WPF-889895-PageSettings_Issue_Fixes

@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 26, 2024

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: WPF-889895-PageSettings_Issue_Fixes
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 26, 2024

Build Status: INPROGRESS 🔃
Build Location: WPF-889895-PageSettings_Issue_Fixes

@SyncfusionBuild
Copy link
Contributor

SyncfusionBuild commented Jun 26, 2024

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: WPF-889895-PageSettings_Issue_Fixes
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

KarkuvelRajan
KarkuvelRajan approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@KarkuvelRajan KarkuvelRajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@KarkuvelRajan KarkuvelRajan merged commit 98b903e into hotfix/hotfix-v26.1.35 Jun 26, 2024
@KarkuvelRajan KarkuvelRajan deleted the WPF-889895-PageSettings_Issue_Fixes branch June 26, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KarkuvelRajan KarkuvelRajan KarkuvelRajan approved these changes

Assignees

@SatishRaj4377 SatishRaj4377

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SatishRaj4377 @SyncfusionBuild @KarkuvelRajan @satishraj-sf4377