Use separate notification channel while monitoring run conditions#1046
Conversation
|
Should have waited for the build to finish, but the toolchain compilation takes ages. |
| <string name="notification_crash_text">Click to view logs</string> | ||
|
|
||
| <string name="notifications_persistent_channel">Persistent notification</string> | ||
| <string name="notifications_persistent_channel">Syncthing active</string> |
There was a problem hiding this comment.
I think this should use a new name, otherwise the existing translations for "Persistent notification" will keep being active.
There was a problem hiding this comment.
No, I just wanted to rename the channel. I tested it out, it works. No new channel is created, but the display name of the channel has been updated from "Persistent notification" to "Syncthing active", which now fits better.
There was a problem hiding this comment.
Oh, I understand what you mean, I misread. You are right about the translations, of course.
There was a problem hiding this comment.
Edit: *** - didn't see your last comment before posting the following.
Sure in English there's not going to be a problem, I am thinking about the translation system: Is it smart enough to detect the change and remove all existing translations for the notifications_persistent_channel string? Otherwise the existing translations of "Persistent notification" will keep being used, while new translations for "Syncthing active" should be used.
There was a problem hiding this comment.
Unfortunately I've never cared about the translations yet. I'm not sure how they are done. Are they imported manually? I'll have a look and if it proves to be a problem, I'll either remove the current translations there and/or rename the key, as appropriate.
There was a problem hiding this comment.
I believe transifex automatically imports/reads this file and the translations then need to be imported/committed manually (e.g. 8f324a8). I requested access to German&French translations to check what happened to the string after this merge - maybe anyone else with access could check it too, because I won't be active anymore for a bit over a week past midday today :)
ghost
mentioned this pull request
4 participants
As discussed in #998, or #1021, since Android 8.0 we are currently forced to have the service running with foreground priority in order to receive broadcasts. This leads to the "Syncthing is disabled" notification, which is annoying.
Splitting the "Syncthing is active" and "Syncthing is disabled" into two separate notification channels at least allows on 8.0+ to hide or at least make the "Syncthing is disabled" notification less intrusive.
Unfortunately this advantage remains only for 8.0+, so this is not a fix for the issues referenced above.