Skip to content

chore(api): deflake TestHTTPLogin on Windows#10667

Merged
calmh merged 2 commits intosyncthing:mainfrom
calmh:jb/deflake4
Apr 24, 2026
Merged

chore(api): deflake TestHTTPLogin on Windows#10667
calmh merged 2 commits intosyncthing:mainfrom
calmh:jb/deflake4

Conversation

@calmh
Copy link
Copy Markdown
Member

@calmh calmh commented Apr 24, 2026

Hopefully deflakes TestHTTPLogin on Windows, where it currently often times out, presumably in the config saving stage after already having started a shutdown of the API and being CPU constrained due to password hashing.

calmh added 2 commits April 24, 2026 14:59
Hopefully deflakes TestHTTPLogin on Windows, where it currently often
times out, presumably in the config saving stage after already having
started a shutdown of the API and being CPU constrained due to password
hashing.

Signed-off-by: Jakob Borg <jakob@kastelo.net>
Signed-off-by: Jakob Borg <jakob@kastelo.net>
@github-actions github-actions Bot added the chore label Apr 24, 2026
@calmh calmh added the trivial The PR is considered a trivial change, for review purposes label Apr 24, 2026
@calmh calmh merged commit 97fb677 into syncthing:main Apr 24, 2026
26 checks passed
@calmh calmh deleted the jb/deflake4 branch April 25, 2026 13:37
calmh added a commit to vvaswani/syncthing that referenced this pull request Apr 26, 2026
* main:
  fix(strelaypoolsrv): retry "not found" errors in registration check
  fix(strelaypoolsrv): correct remote address logging
  fix(strelaysrv): properly use bind address for outgoing requests (fixes syncthing#10658) (syncthing#10659)
  chore(api): deflake TestHTTPLogin on Windows (syncthing#10667)
  build: parallelise linux builds slightly (syncthing#10666)
  fix(gui): fix tabs visually disabled but still clickable during ignore patterns setup (fixes syncthing#10634) (syncthing#10651)
  chore(scanner): deflake TestStopWalk (syncthing#10664)
  chore(model): deflake TestCompletionEmptyGlobal (syncthing#10663)
  chore(model): deflake cluster config tests (syncthing#10662)
  fix(gui): fallback to folder ID when label is empty in remove dialog (syncthing#10657)
  chore(model): more efficient tracking of renames during scan (syncthing#10653)
  chore: trivial fixes (syncthing#10650)
  chore(gui, man, authors): update docs, translations, and contributors
  chore(gui, man, authors): update docs, translations, and contributors
  fix(gui): order folders alphabetically and ensure local device stays hidden (ref syncthing#10563, ref syncthing#10631)
calmh added a commit to luizluca/syncthing that referenced this pull request Apr 26, 2026
* upstream/main: (47 commits)
  feat: make http session cookie path & duration configurable (fixes syncthing#10522) (syncthing#10632)
  fix(strelaypoolsrv): retry "not found" errors in registration check
  fix(strelaypoolsrv): correct remote address logging
  fix(strelaysrv): properly use bind address for outgoing requests (fixes syncthing#10658) (syncthing#10659)
  chore(api): deflake TestHTTPLogin on Windows (syncthing#10667)
  build: parallelise linux builds slightly (syncthing#10666)
  fix(gui): fix tabs visually disabled but still clickable during ignore patterns setup (fixes syncthing#10634) (syncthing#10651)
  chore(scanner): deflake TestStopWalk (syncthing#10664)
  chore(model): deflake TestCompletionEmptyGlobal (syncthing#10663)
  chore(model): deflake cluster config tests (syncthing#10662)
  fix(gui): fallback to folder ID when label is empty in remove dialog (syncthing#10657)
  chore(model): more efficient tracking of renames during scan (syncthing#10653)
  chore: trivial fixes (syncthing#10650)
  chore(gui, man, authors): update docs, translations, and contributors
  chore(gui, man, authors): update docs, translations, and contributors
  fix(gui): order folders alphabetically and ensure local device stays hidden (ref syncthing#10563, ref syncthing#10631)
  fix(gui): don't show local device under remote devices (ref syncthing#10563) (syncthing#10631)
  policy: pushing invalidates PR approval
  docs: add release notes for 2.1
  feat(gui, config): support simple folder grouping (fixes syncthing#2070) (syncthing#10563)
  ...
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Apr 26, 2026
---------------------------------------------------------------------------------------
applewin.mk 186bcadcf5ebda2b6e6b7f578ab2820907a1bffa # Version: Commits on Apr 26, 2026
---------------------------------------------------------------------------------------
Merge pull request #390 from audetto/update

Minor corrections.,

-------------------------------------------------------------------------------------
azahar.mk ec6a0dd1c814d0ee22a9feeb73c7de2e530830b4 # Version: Commits on Apr 26, 2026
-------------------------------------------------------------------------------------
ci: Migrate Transifex runner to `latest` tag

The `transifex` tag has now been removed due to a seperate image no longer being necessary,

------------------------------------------------------------------------------------------
dolphin-emu.mk af15769d57ddaf4b3f79801a2174c67a19150050 # Version: Commits on Apr 26, 2026
------------------------------------------------------------------------------------------
Merge pull request #14569 from Simonx22/android/convert-gamefilecachemanager-to-kotlin

Android: Convert GameFileCacheManager to Kotlin,

------------------------------------------------------------------------------------------
duckstation.mk 23d79f8a5dfaf778f2a680bcc549e9b92d94756d # Version: Commits on Apr 26, 2026
------------------------------------------------------------------------------------------
Qt: Fix themed slider disabled state,

-------------------------------------------------------------------------------------
hatari.mk 9594e78b4e3b4d769779bcb276eae165ddf95a6b # Version: Commits on Apr 26, 2026
-------------------------------------------------------------------------------------
Add a FreeBSD and OpenBSD compilation test on Github

Using the vmactions on Github, it is also possible to test

compilation on various BSD flavors on Github. The .cirrus.yml

file is now not required anymore, so we can remove it.,

----------------------------------------------------
pcsx2.mk v2.7.293 # Version: Commits on Apr 26, 2026
----------------------------------------------------
- [GS:MTL: AA1 Support](PCSX2/pcsx2#14354)

-------------------------------------------------
vice.mk r46084 # Version: Commits on Apr 26, 2026
-------------------------------------------------
null

-------------------------------------------------------------------------------------------
xenia-canary.mk cff0773e00d756af6669b127ef6c09562ace62c3 # Version: Commits on Apr 26, 2026
-------------------------------------------------------------------------------------------
[HID] Portal: Simplified device searching procedure,

-------------------------------------------------------------------------------------------
xenia-native.mk cff0773e00d756af6669b127ef6c09562ace62c3 # Version: Commits on Apr 26, 2026
-------------------------------------------------------------------------------------------
[HID] Portal: Simplified device searching procedure,

-----------------------------------------------------------------------------------
ymir.mk 8a74e9bea42887633ed65ed323f0049b02d29b70 # Version: Commits on Apr 26, 2026
-----------------------------------------------------------------------------------
perf(VDP2): Microoptimize part of the rotparam table calculation,

------------------------------------------------------------------------------------------
devilutionx.mk 7ebd4ed9000b24cb9d721c9e5339bf5a498be76c # Version: Commits on Apr 13, 2026
------------------------------------------------------------------------------------------
Fix leave shack with visual store,

-----------------------------------------------------------
syncthing.mk v2.1.0-rc.1 # Version: Commits on Apr 26, 2026
-----------------------------------------------------------
## Major changes in 2.1

- Devices and folders can now be grouped in the GUI by setting the new

  `group` attribute.

- HTTP and HTTPS proxies with support for CONNECT can now be used, in

  addition to the existing support for SOCKS proxies (the environment

  variable `all_proxy=https://...`).

- Block indexing can be turned off for folders where it's more desirable to

  optimise for reduced database size and overhead than minimal transfer

  size (the `blockIndexing` attribute on folder configuration).

- GUI login session duration can be configured to be longer or shorter than

  the default one week, or set to infinitely long. The cookie path can also

  be adjusted. (The `sessionCookieDurationS` and `sessionCookiePath`

  attributes in the GUI configuration.)

This release is also available as:

* APT repository: https://apt.syncthing.net/

* Docker image: `docker.io/syncthing/syncthing:2.1.0-rc.1` or `ghcr.io/syncthing/syncthing:2.1.0-rc.1`

  (`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version)

## What's Changed

### Fixes

* fix(stdiscosrv): close file descriptor on flush error in write by @cuiweixie in syncthing/syncthing#10615

* fix(gui): disable autocomplete for folder password by @bt90 in syncthing/syncthing#10342

* fix(protocol): limit size of incoming request messages by @calmh in syncthing/syncthing#10629

* fix(gui): don't show local device under remote devices (ref #10563) by @maen-bn in syncthing/syncthing#10631

* fix(gui): order folders alphabetically and ensure local device stays hidden (ref #10563, ref #10631) by @maen-bn in syncthing/syncthing#10637

* fix(gui): fallback to folder ID when label is empty in remove dialog by @RealCharlesChia in syncthing/syncthing#10657

* fix(gui): fix tabs visually disabled but still clickable during ignore patterns setup (fixes #10634) by @JRNitre in syncthing/syncthing#10651

* fix(strelaysrv): properly use bind address for outgoing requests (fixes #10658) by @calmh in syncthing/syncthing#10659

### Features

* feat(gui, config): support simple folder grouping (fixes #2070) by @maen-bn in syncthing/syncthing#10563

* feat: make http session cookie path & duration configurable by @vvaswani in syncthing/syncthing#10632

* feat(dialer): add HTTP/HTTPS proxy support via CONNECT by @luizluca in syncthing/syncthing#10572

* feat: make block indexing configurable by @calmh in syncthing/syncthing#10608

### Other

* chore: remove tracking inode change time by @calmh in syncthing/syncthing#10579

* build(deps): temporarily switch to fork of gateway discovery library (fixes #10593) by @marbens-arch in syncthing/syncthing#10594

* build: extract github.ref_name expression to env mapping by @dagecko in syncthing/syncthing#10624

* build: pin 20 third-party actions to immutable commit SHAs by @dagecko in syncthing/syncthing#10625

* build: have dependabot group PRs and use cooldown by @calmh in syncthing/syncthing#10630

* chore: trivial fixes by @calmh in syncthing/syncthing#10650

* chore(model): more efficient tracking of renames during scan by @calmh in syncthing/syncthing#10653

* chore(model): deflake cluster config tests by @calmh in syncthing/syncthing#10662

* chore(model): deflake TestCompletionEmptyGlobal by @calmh in syncthing/syncthing#10663

* chore(scanner): deflake TestStopWalk by @calmh in syncthing/syncthing#10664

* build: parallelise linux builds slightly by @calmh in syncthing/syncthing#10666

* chore(api): deflake TestHTTPLogin on Windows by @calmh in syncthing/syncthing#10667

## New Contributors

* @cuiweixie made their first contribution in syncthing/syncthing#10615

* @dagecko made their first contribution in syncthing/syncthing#10624

* @maen-bn made their first contribution in syncthing/syncthing#10563

* @RealCharlesChia made their first contribution in syncthing/syncthing#10657

* @JRNitre made their first contribution in syncthing/syncthing#10651

* @vvaswani made their first contribution in syncthing/syncthing#10632

* @luizluca made their first contribution in syncthing/syncthing#10572

**Full Changelog**: syncthing/syncthing@v2.0.16...v2.1.0-rc.1,

----------------------------------------------------------------------------------------
retroarch.mk 5f61ff9ad12af2db9af37173781affc6cddfb1c4 # Version: Commits on Apr 26, 2026
----------------------------------------------------------------------------------------
Fix warning '/* within block comment',

---------------------------------------------------------------------------------------
vpinball.mk b3afbfc0703b64ac59b1d05e0d4916c47649f6a3 # Version: Commits on Apr 26, 2026
---------------------------------------------------------------------------------------
LiveUI: fix font scale on landscape displays,

--------------------------------------------------------------------------------------
yquake2.mk 3ee26a9140d6d1c19b3a833e2c089ed2a0f5535a # Version: Commits on Apr 26, 2026
--------------------------------------------------------------------------------------
refresh: share CommonAllocBlock,

---------------------------------------------------------------------------------------------
libretro-citra.mk ec6a0dd1c814d0ee22a9feeb73c7de2e530830b4 # Version: Commits on Apr 26, 2026
---------------------------------------------------------------------------------------------
ci: Migrate Transifex runner to `latest` tag

The `transifex` tag has now been removed due to a seperate image no longer being necessary,

---------------------------------------------------------------------------------------------
libretro-fbneo.mk 8e96a4a38506054b2d9ceb9f5e93689f143359e7 # Version: Commits on Apr 26, 2026
---------------------------------------------------------------------------------------------
(libretro) update files,

----------------------------------------------------------------------------------------------
libretro-stella.mk de54f8205cefc1e4bdecfd408ae3cb77c4d06135 # Version: Commits on Apr 26, 2026
----------------------------------------------------------------------------------------------
Fix size_t warning.,

---------------------------------------------------------------------------------------------
libretro-vba-m.mk d112ea8b94926535f42be32048f33e5186acbff6 # Version: Commits on Apr 26, 2026
---------------------------------------------------------------------------------------------
More timing fixes,

--------------------------------------------------------------------------------------------
slang-shaders.mk cc71b5eff24a962bd055a92d2032f806635fdf97 # Version: Commits on Apr 26, 2026
--------------------------------------------------------------------------------------------
add a note to a parameter (#905),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore trivial The PR is considered a trivial change, for review purposes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant