chore(gui): cache input type in each advanced settings category#9802
Merged
calmh merged 2 commits intosyncthing:mainfrom Dec 1, 2024
Merged
chore(gui): cache input type in each advanced settings category#9802calmh merged 2 commits intosyncthing:mainfrom
calmh merged 2 commits intosyncthing:mainfrom
Conversation
Each section in the advanced settings dialog has similar code to insert repeated input fields for each option. But only the first section (GUI options) was adjusted in syncthing#9743 to avoid calling the inputTypeFor() function repeatedly. Apply the same caching to a locally scoped variable for each ng-repeat entry by defining it in an ng-init directive.
calmh
approved these changes
Dec 1, 2024
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Dec 1, 2024
* upstream/main: chore(gui): cache input type in each advanced settings category (syncthing#9802)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each section in the advanced settings dialog has similar code to insert repeated input fields for each option. But only the first section (GUI options) was adjusted in #9743 to avoid calling the
inputTypeFor()function repeatedly.Apply the same caching to a locally scoped variable for each ng-repeat entry by defining it in an ng-init directive.