[CMake] Incomplete info on About dialog box

[Keyikedalube]

Synfig version & platform:
Building from source
Debian sid

Issue description:

1. Missing Development version
2. Unknown Synfig version
   

I don't know where & how Autotools parses information from but I think CMake is reading it directly from the macro header defined in the source file itself.

synfig/synfig-studio/src/gui/dialogs/about.cpp

Lines 60 to 67 in fa78a4d

	#ifndef PACKAGE_NAME
	#define PACKAGE_NAME "Synfig Studio"
	#endif
	#ifndef VERSION
	#define VERSION "unknown"
	#endif

[rahmanuh]

Hi again, this issue is interesting. May I work on this?

[Keyikedalube]

If you can understand CMake sure :)

Just check out the code first and if you can determine a fix, then you can request maintainers to assign this issue to you. I haven't figured how to solve this but I'm guessing the cause is from the build generator (CMake).

[rahmanuh]

Okay. I will study the code first.

[AYESDIE]

The Development Version part here can be fixed by using add_definitions where you can pass the git info which is already managed by cmake/SynfigFindGit.cmake.

About Synfig Version, it's weird to see it unknown when it's already being set in the beginning, as you can see in this image too.

synfig/synfig-studio/src/gui/dialogs/about.cpp

Line 82 in fa78a4d

set_version(VERSION);

[rahmanuh]

I am not sure set_version(VERSION) really sets the version, because when I try to see the definition, it points to:

synfig/synfig-core/src/synfig/layers/layer_mime.cpp

Line 79 in fa78a4d

Layer_Mime::set_version(const String &ver)

But why it successfully write 1.5.0 below Synfig Studio? 😕

---

Anyone has an idea, why this has a comment "this needs some fixes to work"?

synfig/synfig-studio/src/gui/CMakeLists.txt

Line 6 in fa78a4d

set(SHOW_EXTRA_INFO OFF) # this needs some fixes to work

[Keyikedalube]

ping @AYESDIE @ice0

[AYESDIE]

On checking the code, I can see that we are using Gtk::AboutDialog as a parent class for our About dialog. So in our case, we are calling set_version() from the parent class (which is Gtk::AboutDialog here). You can check their documentation over here. It works as intended too so there's no issue with that over here.

Tracing the Unknown part got me to this file. Using add_definitions can help you define VERSION which will fix that issue.

synfig/synfig-core/src/synfig/main.cpp

Lines 114 to 122 in dfcfdf9

	const char *
	synfig::get_version()
	{
	#ifdef VERSION
	return VERSION;
	#else
	return "Unknown";
	#endif
	}

---

That seems like part of some old code and it can be removed. The SHOW_EXTRA_INFO part is managed by this part of the code on that same file.

synfig/synfig-studio/src/gui/CMakeLists.txt

Lines 22 to 25 in dfcfdf9

	if (CMAKE_BUILD_TYPE MATCHES Debug)
	add_definitions("-DSHOW_EXTRA_INFO")
	add_definitions(-DETL_VERSION="${ETL_VERSION}")
	endif()

[rahmanuh]

Thanks for your hints. The version now is not Unknown. I do
+add_definitions(-DVERSION="${STUDIO_VERSION_MAJOR}.${STUDIO_VERSION_MINOR}.${STUDIO_VERSION_PATCH}")
in this file

synfig/synfig-core/src/synfig/CMakeLists.txt

Lines 5 to 9 in 5d0abc1

	## Main target: libsynfig
	## TODO: optional static linking?
	add_library(synfig SHARED "")
	message(STATUS "MLT DIR: ${MLT_INCLUDE_DIRS}")

---

Regarding the DEVEL_VERSION part, whenever I add_definition(-DDEVEL_VERSION) in Line 21, there is error: Segmentation Fault (Core dumped) when I launch SynfigStudio.

(synfigstudio:11525): IBUS-WARNING **: 09:47:15.490: Unable to connect to ibus: Could not connect: Connection refused
synfig(11525) [09:47:15] info: Init About Dialog...
Segmentation fault (core dumped)

I think it is because of autorevision.h not defining DEVEL_VERSION. I do not understand why. I suppose it will automatically generated if we add_definition(-DDEVEL_VERSION) in here

[rahmanuh]

[Update]
Finally, I fix it 😃

Will make a PR later