Restore Defaults is applied only on OK pressed#1445
Merged
ice0 merged 8 commits intosynfig:masterfrom Nov 19, 2020
Merged
Conversation
Member
Author
|
Includes also a missing space in the Revert to saved confirm dialog. |
Member
Author
|
There is a functional issue with the current implementation. Some values have their signal connected to a function which does change the settings of Synfig. synfig/synfig-studio/src/gui/dialogs/dialog_setup.cpp Lines 829 to 834 in 6d3f75f Probably the best way to deal with it is to remove those parts that in practice don't give any advantage to the user. |
ice0
reviewed
May 27, 2020
Member
Author
|
@ice0 this request is ready. Do you need me to force-push it? |
Collaborator
|
@FirasH yes, can you rebase it? |
Member
Author
Done 👍 |
Collaborator
|
Merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1415