Skip to content

Restore Defaults is applied only on OK pressed#1445

Merged
ice0 merged 8 commits intosynfig:masterfrom
FirasH:issue-1415
Nov 19, 2020
Merged

Restore Defaults is applied only on OK pressed#1445
ice0 merged 8 commits intosynfig:masterfrom
FirasH:issue-1415

Conversation

@FirasH
Copy link
Member

@FirasH FirasH commented May 24, 2020

Fixes #1415

@FirasH
Copy link
Member Author

FirasH commented May 24, 2020

Includes also a missing space in the Revert to saved confirm dialog.

@FirasH FirasH changed the title Add confirm dialog for Restore Defaults in Preferences Restore Defaults is applied only on OK pressed May 24, 2020
@FirasH
Copy link
Member Author

FirasH commented May 25, 2020

There is a functional issue with the current implementation.

Some values have their signal connected to a function which does change the settings of Synfig.
This means that if for example autosave is disabled, when Cancel is pressed it won't be reverted to current settings:

void
Dialog_Setup::on_autobackup_changed()
{
auto_backup_interval.set_sensitive(toggle_autobackup.get_active());
App::auto_recover->set_enabled(toggle_autobackup.get_active());
}

Probably the best way to deal with it is to remove those parts that in practice don't give any advantage to the user.

@FirasH
Copy link
Member Author

FirasH commented Nov 18, 2020

@ice0 this request is ready. Do you need me to force-push it?

@ice0
Copy link
Collaborator

ice0 commented Nov 18, 2020

@FirasH yes, can you rebase it?

@FirasH
Copy link
Member Author

FirasH commented Nov 18, 2020

@FirasH yes, can you rebase it?

Done 👍

@ice0 ice0 merged commit 3d32977 into synfig:master Nov 19, 2020
@ice0
Copy link
Collaborator

ice0 commented Nov 19, 2020

Merged. Thank you!

@FirasH FirasH deleted the issue-1415 branch November 19, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shouldn't Preferences > Restore Defaults give the user a chance to confirm?

3 participants