refactor: avoid copying variable on left-rotating vector#3585
Merged
ice0 merged 1 commit intosynfig:masterfrom Feb 3, 2026
Merged
refactor: avoid copying variable on left-rotating vector#3585ice0 merged 1 commit intosynfig:masterfrom
ice0 merged 1 commit intosynfig:masterfrom
Conversation
Problem was in `auto node` (instead of `const auto& node`). Besides, there was a duplicated `if`condition o.O Error reported by Scan Coverity CID 457160
|
Thank you for contributing! ♻️ Code Refactoring
|
ice0
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem was in
auto node(instead ofconst auto& node). Besides, there was a duplicatedifcondition o.OError reported by Scan Coverity CID 457160