-
Notifications
You must be signed in to change notification settings - Fork 1
Watch pending transfer #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -1,5 +1,7 @@ | |||
| package to.bitkit.repositories | |||
|
|
|||
| import androidx.lifecycle.viewModelScope | |||
Check warning
Code scanning / detekt
Detects unused imports Warning
| import to.bitkit.services.LightningService | ||
| import to.bitkit.utils.Logger | ||
| import to.bitkit.utils.ServiceError | ||
| import to.bitkit.viewmodels.TransferViewModel |
Check warning
Code scanning / detekt
Detects unused imports Warning
|
|
||
| Logger.debug("Started to watch order '$orderId'", context = TAG) | ||
|
|
||
| while (!isSettled && error == null) { |
Check warning
Code scanning / detekt
The loop contains more than one break or continue statement. The code should be refactored to increase readability. Warning
| package to.bitkit.models | ||
|
|
||
| import androidx.annotation.StringRes | ||
| import com.synonym.bitkitcore.BtOrderState2 |
Check warning
Code scanning / detekt
Detects unused imports Warning
|
|
||
|
|
Check warning
Code scanning / detekt
Reports consecutive blank lines Warning
|
|
||
|
|
||
|
|
||
| //fun BtOrderState2.toChannelSetupStep() = when(this) { |
Check warning
Code scanning / detekt
Checks if comments have the right spacing Warning
| // BtOrderState2.EXPIRED -> TODO() | ||
| // BtOrderState2.EXECUTED -> TODO() | ||
| // BtOrderState2.PAID -> TODO() | ||
| //} |
Check warning
Code scanning / detekt
Checks if comments have the right spacing Warning
| } | ||
|
|
||
| /* | ||
| * Cache order step |
Check warning
Code scanning / detekt
Detect the alignment of the initial star in a block comment. Warning
|
|
||
| /* | ||
| * Cache order step | ||
| * Start cached order watch |
Check warning
Code scanning / detekt
Detect the alignment of the initial star in a block comment. Warning
| /* | ||
| * Cache order step | ||
| * Start cached order watch | ||
| * Update order status |
Check warning
Code scanning / detekt
Detect the alignment of the initial star in a block comment. Warning
| * Cache order step | ||
| * Start cached order watch | ||
| * Update order status | ||
| * */ |
Check warning
Code scanning / detekt
Detect the alignment of the initial star in a block comment. Warning
|
Replaced by #283 |
Related to #268
This PR implements the code to keep wathcing the blocktank orders after the app restart
Description
Preview
QA Notes