Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Aug 7, 2025

Related: #49
Design: Figma v57 Send - Set Custom Fee

This PR adds the feature to set a custom fee rate in satPerVb during the onchain send flow.

Description

  • Send custom fee screen UI & logic
  • Use pixel perfect sizing for sheet topbar and drag handle
  • Fix to navigate back on speed click in settings
  • Show spinner while loading fee amount on review screen
  • Validate against max and min fee limits and disable invalid speeds
    • Fee must not exceed 50% of available balance and it must be less than the remaining funds after send

Preview

Screen_recording_20250808_003801.mp4

QA Notes

Test Custom Fee Screen:

  • test with custom fee already set via settings
  • test by setting different custom speeds
  • test by switching from fee rate preset to custom
  • test validation by using amount close to max

@ovitrif ovitrif force-pushed the feat/send-fee-custom branch from a089da0 to d274def Compare August 7, 2025 23:05
@ovitrif ovitrif marked this pull request as ready for review August 8, 2025 07:51
@jvsena42
Copy link
Member

jvsena42 commented Aug 8, 2025

I see a tendency for wallets to allow a fee rate smaller than 1. I wonder when we should start thinking about this to Bitkit

@ovitrif ovitrif requested a review from jvsena42 August 8, 2025 12:02
@ovitrif ovitrif self-assigned this Aug 8, 2025
jvsena42
jvsena42 previously approved these changes Aug 8, 2025
@ovitrif ovitrif merged commit 601363c into master Aug 8, 2025
5 checks passed
@ovitrif ovitrif deleted the feat/send-fee-custom branch August 8, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants