Attach tags asynchronously #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/to/bitkit/repositories/ActivityRepo.kt
ovitrif
approved these changes
Sep 1, 2025
| return@withContext Result.failure(e) | ||
| } | ||
| updateActivitiesMetadata() | ||
| syncTagsMetaData() |
Collaborator
There was a problem hiding this comment.
nit: MetaData caps NOK, should be Metadata
| if (db.tagMetadataDao().getAll().isEmpty()) return@withContext | ||
| val lastActivities = getActivities(limit = 10u).getOrNull() ?: return@withContext | ||
| Logger.debug("syncTagsMetaData called") | ||
| lastActivities.forEach { activity -> |
Collaborator
There was a problem hiding this comment.
Computation inside forEach block should be parallelized later, when optimising for performance.
| ): Result<Unit> = withContext(bgDispatcher) { | ||
| return@withContext runCatching { | ||
|
|
||
| if (tags.isEmpty()) throw InvalidParameterException("tags must not be empty") |
Collaborator
There was a problem hiding this comment.
InvalidParameterException is not intended for such uses, apparently.
Should be replaced by IllegalArgumentException
Member
Author
There was a problem hiding this comment.
I intended to implement IllegalArgumentException. It was probably the autocomplemente, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #322
Description
Currently, the app only tries to attach pending tags when the event is received, so it may fail if the activity takes to long to be added.
This implementation syncs the pending tags on every activity sync
Preview
onchain-receive.mp4
onchain-send.mp4
ln-receive.mp4
ln-send.mp4
QA Notes
Tests
OnChain
Lightning