Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Sep 2, 2025

Closes #319 (comment)
Closes #319 (comment)
Closes #319 (comment)

Description

This Pr implements parallelization to activity syncing and fixes some code style issues

Preview

transfer.mp4
ln-receive.mp4
ln-send.mp4
onchain-receive.mp4
onchain-send-rbf.mp4
cpfp.mp4

QA Notes

Tested:

  • Transfer

  • OnChain

    • RBF -> Check if the activity was updated correctly
    • CPFP -> Check if the activity was updated correctly
    • Send -> Check activity details
    • Receive -> Check activity details
    • Add tags before sending -> send -> check if tags were attached in activity details
    • Create an invoice -> add tags -> receive -> check if tags were attached in activity details
  • Lightning

    • Send -> Check activity details
    • Receive -> Check activity details
    • Add tags before sending -> send -> check if tags were attached in activity details
    • Create an invoice -> add tags -> receive -> check if tags were attached in activity details

@jvsena42 jvsena42 self-assigned this Sep 2, 2025
@jvsena42 jvsena42 marked this pull request as draft September 2, 2025 11:20
@jvsena42 jvsena42 marked this pull request as ready for review September 2, 2025 12:01
@jvsena42 jvsena42 marked this pull request as draft September 2, 2025 12:07
@jvsena42 jvsena42 marked this pull request as ready for review September 2, 2025 12:32
@jvsena42 jvsena42 requested a review from ovitrif September 3, 2025 09:37
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Tests

  • tested all test cases from PR description 🟢

@ovitrif ovitrif merged commit 7a48a8e into master Sep 4, 2025
5 checks passed
@ovitrif ovitrif deleted the refactor/parallelize-activity-syncing branch September 4, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants