Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Aug 28, 2025

Closes #325, Closes #328

Description

This PR fixes the fee above 10 USD sanity check. The method was using the full sending amount instead of just the fee value.
Also check all the sanity checks instead of skipping the others after confirming the first one

Preview

sanity_checks.mp4
fee_check.mp4

QA Notes

Steps to reproduce:

  1. Have ₿ 100 000 000 in the wallet.
  2. Send ₿ 51 000 000 and swipe to confirm, i.e., over 50% of funds.
  3. Notice the sending over 50% of balance warning pop-up appearing.
  4. Cancel the tx.
  5. Enable the warning for sending over 100$. (Settings > Security and Privacy > Warn when sending over $100)
  6. Go back and send again ₿ 51 000 000. Swipe to confirm.
  7. Notice the sending over 100$ warning pop-up appearing.
  8. Confirm pop-up.
  9. Try to send with a fee of above 10 USD
  10. Notice the pop-up appearing
  11. Confirm pop-up
  12. Try to send with a fee of above half the sending amount
  13. Notice the pop-up
  14. Confirm pop-up
  15. No other pop-up should be displayed

@jvsena42 jvsena42 self-assigned this Aug 28, 2025
@jvsena42 jvsena42 changed the title fix: Fee above 10 USD sanity check fix: Fee above 10 USD sanity check and don't skip checks Aug 28, 2025
@jvsena42 jvsena42 requested a review from ovitrif August 28, 2025 11:23
@piotr-iohk
Copy link
Collaborator

Locally tested #325 and #328 against this branch. Scenarios are passing 👍

Copy link
Collaborator

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jvsena42 jvsena42 merged commit d3ce231 into master Aug 28, 2025
5 checks passed
@jvsena42 jvsena42 deleted the fix/fee-over-10-usd-warning branch August 28, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sending tx: single warning dialog when two expected Over $10 fee warning pop-up when fee is below, on sending transaction

3 participants