Skip to content

Conversation

@piotr-iohk
Copy link
Collaborator

Description

Make ScanPrompt, QRDialog, QRInput visible as resource-id. Similar case as in #320.

Preview

QA Notes

@piotr-iohk piotr-iohk self-assigned this Sep 1, 2025
@ovitrif
Copy link
Collaborator

ovitrif commented Sep 1, 2025

Are you having these issues (related to e2e test tags being hidden) in bottom sheets?

Asking because, IIRC the global semantics modifier doesn't apply to dialogs or bottom sheets, according to some online docs I read

// global semantics modifier for this
.semantics {
   testTagsAsResourceId = true
}

PS. I guess you meant to fix this for the QR scanning screen in the send sheet, hence me asking you to confirm.

Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but ideally we should find a general fix, instead of filling the codebase with this modifier.

@piotr-iohk
Copy link
Collaborator Author

@ovitrif Yes, I've been seing this every now and then on some dialogs etc. like:

I'm not sure where some global modifier should be placed such that it fixes this generally though.

@ovitrif
Copy link
Collaborator

ovitrif commented Sep 1, 2025

@piotr-iohk Makes perfect sense. It's because the sheets and dialogs are not in the same UI tree, they're added separately by the Android framework.

I'm not sure where some global modifier should be placed such that it fixes this generally though.

Will look into a fix myself 👍🏻 , it's not that easy, there won't be just a single place, but more.

@piotr-iohk piotr-iohk merged commit af536da into master Sep 1, 2025
5 checks passed
@piotr-iohk piotr-iohk deleted the make-test-tags-visible branch September 1, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants