Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Sep 4, 2025

Design Figma v57

This PR implements routing fee estimation in the send LN flow,
using the new APIs from the ldk-node fork release v0.6.2-rc.3.

Description

Changes:

  • implement routing fee estimation in send lightning flow
  • add routing fee estimation tests
  • fix data stores testability
  • upgrade ldk-node to v0.6.2-rc.3
  • upgrade agp to 8.13.0

Preview

LN - ₿ LN - $
Onchain - ₿ Onchain - $

QA Notes

Test:

  • send lightning (BTC) > expect fee displayed
  • send lightning (FIAT) > expect fee displayed
  • send onchain (BTC) > expect no regression
  • send onchain (FIAT) > expect no regression

@ovitrif ovitrif self-assigned this Sep 4, 2025
@ovitrif ovitrif force-pushed the feat/ldk-routing-fees branch 2 times, most recently from 243f001 to 1b083fe Compare September 4, 2025 12:56
@ovitrif ovitrif changed the title feat: routing fee estimation tests feat: routing fee estimation Sep 4, 2025
@coreyphillips
Copy link

Updated bindings with the reverted/fixed electrum-client version can be found here as v0.6.2-rc.3

@ovitrif ovitrif force-pushed the feat/ldk-routing-fees branch from a05bf71 to 43013b8 Compare September 5, 2025 09:31
@ovitrif ovitrif force-pushed the feat/ldk-routing-fees branch from 43013b8 to 5468f23 Compare September 5, 2025 11:05
@ovitrif ovitrif marked this pull request as ready for review September 5, 2025 11:23
@ovitrif ovitrif requested a review from jvsena42 September 5, 2025 11:23
@ovitrif ovitrif enabled auto-merge September 5, 2025 11:23
@ovitrif
Copy link
Collaborator Author

ovitrif commented Sep 5, 2025

Updated bindings with the reverted/fixed electrum-client version can be found here as v0.6.2-rc.3

Thx 🙏🏻 Updated PR to use v0.6.2-rc.3

Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the Bitcoin symbol

@ovitrif
Copy link
Collaborator Author

ovitrif commented Sep 5, 2025

Missing the Bitcoin symbol

Thanks 🙏🏻

  • Fixed in 4ff5b37
  • Updated PR Description with new screenshots and test cases

@ovitrif ovitrif requested a review from jvsena42 September 5, 2025 14:58
@ovitrif ovitrif merged commit 2092faf into master Sep 5, 2025
7 checks passed
@ovitrif ovitrif deleted the feat/ldk-routing-fees branch September 5, 2025 16:31
@ovitrif
Copy link
Collaborator Author

ovitrif commented Sep 17, 2025

This PR also fixed point 9 from:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants