Deeplinks #390

jvsena42 · 2025-09-18T09:50:46Z

Description

Implement deeplink handling

Preview

zero_amount.mp4

with_amount.mp4

only_lightning.mp4

not_initialized_zero_amount.mp4

not_initialized_with_amount.mp4

no_wallet.mp4

Screen_recording_20250918_141851.webm

Screen_recording_20250918_142616.webm

Screen_recording_20250918_142641.webm

QA Notes

Scan a qr code or clink in a URI with the scheme:

Wallet not created > should skip decoding
bitcoin > send flow
lightning > lightning send flow
Node not running > scan invoice with amount > display syncing screen
Node not running > scan invoice with zero amount > display syncing screen
lnurl > LNURL payment flow
lnurlw > LNURL withdraw flow
lnurlc > LNURL channel flow
lnurlp > LNURL payment flow

app/src/main/java/to/bitkit/ui/MainActivity.kt

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt

Copilot

Pull Request Overview

This PR implements deeplink handling functionality for the Bitcoin wallet app, allowing users to initiate payments and other actions through external links and QR codes. The implementation includes support for various schemes including bitcoin, lightning, and LNURL protocols.

Adds deeplink intent handling in the main activity for both app launch and new intents
Integrates deeplink processing with existing scan/payment flow via the AppViewModel
Updates the send confirmation screen to display node syncing state when the Lightning node is not running

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
app/src/main/AndroidManifest.xml	Adds intent filters for deeplinks, universal links, and NFC support with various Bitcoin/Lightning schemes
app/src/main/java/to/bitkit/ui/MainActivity.kt	Integrates deeplink handling in onCreate and onNewIntent methods
app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt	Implements deeplink processing logic and extracts screen transition delay constant
app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt	Passes node running state to the send confirmation screen
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt	Conditionally displays sync view when node is not running and refactors content layout

app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt

app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt

jvsena42 · 2025-09-18T14:55:41Z

Still trying to setup LNURL server

jvsena42 · 2025-09-18T16:56:45Z

doesn't recognize lnurl schemes

Screen_recording_20250918_135353.webm

2025-09-18 13:54:58.805  7179-7237  APP                     to.bitkit.dev                        E  ERROR❌️: Failed to decode scan data: 'lnurl:lnurl1dp68gup69uhnzwfj9ccnvwpwxyuzuvfc8genqvps9amkjargv3exzacnu333s' [InvalidAddress=''] - AppViewModel [AppViewModel.kt:497]
                                                                                                    com.synonym.bitkitcore.DecodingException$InvalidAddress: 
2025-09-18 13:55:13.448  7179-7225  APP                     to.bitkit.dev                        E  ERROR❌️: Failed to decode scan data: 'lnurlw:lnurl1dp68gup69uhnzwfj9ccnvwpwxyuzuvfc8genqvps9amkjargv3exzacnu333s' [InvalidAddress=''] - AppViewModel [AppViewModel.kt:497]

jvsena42 · 2025-09-18T17:55:36Z

drafted to check E2E tests

ovitrif · 2025-09-22T14:11:48Z

@jvsena42 Can I review this?
If yes, please merge again with master 🙏🏻 :

jvsena42 · 2025-09-22T14:15:27Z

Can I review this?

Yes, updating...

app/src/main/java/to/bitkit/utils/AddressChecker.kt

ovitrif

LGTM & works

Tested on Pixel phone with adb:

adb shell am start -W -a android.intent.action.VIEW -d  "<deeplink>" to.bitkit.dev

ovitrif · 2025-09-22T14:54:35Z

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt

+    private fun processDeeplink(uri: Uri) = viewModelScope.launch {
+        if (!walletRepo.walletExists()) return@launch
+
+        val data = uri.toString()
+        delay(SCREEN_TRANSITION_DELAY_MS)
+        handleScan(data.removeLightningSchemes())
+    }
+
+    // Todo Temporaary fix while these schemes can't be decoded
+    private fun String.removeLightningSchemes(): String {
+        return this
+            .replace("lnurl:", "")
+            .replace("lnurlw:", "")
+            .replace("lnurlc:", "")
+            .replace("lnurlp:", "")
+    }


nit: don't really need a separate processDeeplink and removeLightningSchemes functions, would've been ok all in one, probably a bit less code in this class which is already having too many lines of code 🙈

I implemented it like this because removeLightningSchemes should be removed in the future

ovitrif · 2025-09-22T14:56:26Z

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt

        private const val TEN_USD = 10
        private const val MAX_BALANCE_FRACTION = 0.5
        private const val MAX_FEE_AMOUNT_RATIO = 0.5
+        private const val SCREEN_TRANSITION_DELAY_MS = 300L


nit: already having this constant defined in TRANSITION_SCREEN_MS:

bitkit-android/app/src/main/java/to/bitkit/ui/theme/Defaults.kt

Line 115 in 63008ab

const val TRANSITION_SCREEN_MS = AnimationConstants.DefaultDurationMillis.toLong() // 300ms

Thanks, I'll update in #406

jvsena42 added 2 commits September 17, 2025 17:42

feat: manifest intent

e4f11d6

feat: process depp link WIP

d4cb846

jvsena42 self-assigned this Sep 18, 2025

github-advanced-security bot found potential problems Sep 18, 2025

View reviewed changes

app/src/main/java/to/bitkit/ui/MainActivity.kt Dismissed Show dismissed Hide dismissed

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt Fixed Show fixed Hide fixed

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt Fixed Show fixed Hide fixed

jvsena42 added 7 commits September 18, 2025 07:32

feat: check if wallet exists

88aee0d

chore: lint

e7b396e

chore: simplify code

31dee48

chore: simplify code

5b1d0c2

Merge branch 'master' into feat/deeplinks

50daf39

fix: implement screen transition

202d0f6

fix: implement SyncNodeView

29a4314

jvsena42 requested a review from Copilot September 18, 2025 12:59

Copilot AI reviewed Sep 18, 2025

View reviewed changes

app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt Outdated Show resolved Hide resolved

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Sep 18, 2025

View reviewed changes

app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt Dismissed Show dismissed Hide dismissed

refactor: remove repeated variable

65009f8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-advanced-security bot found potential problems Sep 18, 2025

View reviewed changes

app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt Fixed Show fixed Hide fixed

jvsena42 added 2 commits September 18, 2025 11:52

fix: set delay transition to node running

7609d64

chore: lint

9c9394d

jvsena42 marked this pull request as ready for review September 18, 2025 14:54

jvsena42 requested a review from ovitrif September 18, 2025 14:57

jvsena42 added 2 commits September 18, 2025 14:15

fix: remove unrecogized schemes from uri

56ca7bc

fix: remove unrecognized schemes from uri

c595f58

jvsena42 marked this pull request as draft September 18, 2025 17:55

jvsena42 added 3 commits September 18, 2025 15:10

chore: remove unused import

36c8d85

fix: remove comment

1cd7421

chore: add logs

bbd92cd

jvsena42 marked this pull request as ready for review September 22, 2025 10:54

Merge branch 'master' into feat/deeplinks

00a502a

jvsena42 enabled auto-merge September 22, 2025 13:51

Merge branch 'master' into feat/deeplinks

daf2159

ovitrif reviewed Sep 22, 2025

View reviewed changes

app/src/main/java/to/bitkit/utils/AddressChecker.kt Outdated Show resolved Hide resolved

chore: remove logs

8701bb4

ovitrif approved these changes Sep 22, 2025

View reviewed changes

jvsena42 merged commit 05d12bb into master Sep 22, 2025
7 of 8 checks passed

jvsena42 deleted the feat/deeplinks branch September 22, 2025 15:10

jvsena42 mentioned this pull request Sep 22, 2025

Optional and critical updates #406

Merged

2 tasks

Deeplinks #390

Deeplinks #390

Uh oh!

Conversation

jvsena42 commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Preview

QA Notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jvsena42 commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvsena42 commented Sep 18, 2025

Uh oh!

jvsena42 commented Sep 18, 2025

Uh oh!

ovitrif commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvsena42 commented Sep 22, 2025

Uh oh!

Uh oh!

ovitrif left a comment

Choose a reason for hiding this comment

Uh oh!

ovitrif Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

jvsena42 Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ovitrif Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

jvsena42 Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jvsena42 commented Sep 18, 2025 •

edited

Loading

jvsena42 commented Sep 18, 2025 •

edited

Loading

ovitrif commented Sep 22, 2025 •

edited

Loading

jvsena42 Sep 22, 2025 •

edited

Loading

jvsena42 Sep 22, 2025 •

edited

Loading